After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722244 - vaapisink: fix display initialization in GstVideoOverlay implementation
vaapisink: fix display initialization in GstVideoOverlay implementation
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 719412
 
 
Reported: 2014-01-15 09:20 UTC by Holger Kaelberer
Modified: 2014-01-15 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapisink: fix display initialization in GstVideoOverlay implementation (1.59 KB, patch)
2014-01-15 09:20 UTC, Holger Kaelberer 		none Details | Review

Description Holger Kaelberer 2014-01-15 09:20:46 UTC 
Created attachment 266342 [details] [review]
vaapisink: fix display initialization in GstVideoOverlay implementation

When gst_vaapisink_video_overlay_set_window_handle() is called early, before the pipeline has been set to PLAYING, the display has not yet been initialized and _PLUGIN_BASE_DISPLAY_TYPE() is not yet up-to-date. For this reason the foreign XID is not attached.

With this patch _ensure_display() is called earlir
Comment 1 Gwenole Beauchesne 2014-01-15 09:49:25 UTC 
OK, this one looks simple enough that I can include it now. :)
Comment 2 Gwenole Beauchesne 2014-01-15 10:27:32 UTC 
Applied. Thanks.
Comment 3 Gwenole Beauchesne 2014-01-15 10:27:41 UTC 
commit f8666e2cae518c0514c3b2944e4607502f7ba350
Author: Holger Kaelberer <hk@getslash.de>
Date:   Wed Jan 15 10:05:45 2014 +0100

    vaapisink: fix display initialization in GstVideoOverlay implementation.
    
    When gst_vaapisink_video_overlay_set_window_handle() is called early,
    before the pipeline has been set to PLAYING, the display has not yet
    been initialized and _PLUGIN_BASE_DISPLAY_TYPE() is not yet
    up-to-date. For this reason the foreign XID is not attached.
    
    Now _ensure_display() is called earlier.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722244
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>