GNOME Bugzilla – Bug 722151
Addressbook functionality should be documented in user help
Last modified: 2017-04-12 13:55:09 UTC
This is a companion to Bug #722150. There doesn't seem to be any information on how addressbooks or addressbook switching works. It'd be good to add a section to explain this.
In Bug #722150, Allan posted an explanation of how addressbook switching works: "New contacts will be added to the selected address book. You are able to view but not edit contacts from other address books."
Created attachment 348270 [details] [review] Fix bug 722151 - update Contacts first run Add the following new sentence to Starting contacts section: "All new contacts you create will be saved to the address book you choose. You are also able to view and edit contacts in other address books." This fixes bug 722151 when a user might have an online account configured with contacts and a local address book. I confirmed users can edit their online account contacts even after choosing a local addressbook at first run.
Comment on attachment 348270 [details] [review] Fix bug 722151 - update Contacts first run Just a few nits. >Add the following new sentence to Starting contacts section: >"All new contacts you create will be saved to the address book you choose. You are also able to view and edit contacts in other address books." This fixes bug 722151 when a user might have an online account configured with contacts and a local address book. I confirmed users can edit their online account contacts even after choosing a local addressbook at first run. It's better to wrap these lines at 72 characters. See https://wiki.gnome.org/Git/CommitMessages. >@@ -29,7 +36,9 @@ > > <p>If you have <link xref="accounts">online accounts</link> configured, they > are listed with <gui>Local Address Book</gui>. Select an item from the >- list and click <gui style="button">Done</gui>.</p> >+ list and click <gui style="button">Done</gui>. All new contacts you create >+ will be saved to the address book you choose. You are also able to view and >+ edit contacts in other address books.</p> Remove the double spaces at the end of sentences.
Created attachment 348367 [details] [review] Fix bug 722151 Add the following new sentence to Starting contacts section: All new contacts you create will be saved to the address book you choose. You are also able to view and edit contacts in other address books." Add feedback from comment 3 in the bug to only include single space when starting a new sentence.
Paul, could you squash the two patches into one with: git rebase -i HEAD~2 Run in the branch where your patches are applied? Thanks!
Created attachment 349700 [details] [review] Update fix with feedback from comments Thanks for the feedback. I did git rebase -i HEAD~2, but git bz wouldn't work after that. I then fixed a contraction in the last paragraph and did another commit, but git bz wouldn't apply the patch, so adding it manually. Let me know if it doesn't apply and I can try again.
Committed: https://git.gnome.org/browse/gnome-user-docs/commit/?id=da03d52480894e0a7b3fbcef549b89fbfeae9c93