Created attachment 266182 [details] [review]
Use new prompt style

Created attachment 266183 [details] [review]
Use header bar on file chooser

Created attachment 266184 [details] [review]
Use header bar for document stats

Created attachment 266185 [details] [review]
Use header bar for preferences dialog

Created attachment 266186 [details] [review]
Use header bar in highlight mode dialog

Created attachment 266187 [details] [review]
Use header bar in encoding dialog

Review of attachment 266187 [details] [review]:

See comment

::: gedit/gedit-encodings-dialog.c
@@ +407,3 @@
 {
+	return GTK_WIDGET (g_object_new (GEDIT_TYPE_ENCODINGS_DIALOG,
+                                         "use-header-bar", TRUE,

fix indentation vs alignment

Review of attachment 266187 [details] [review]:

::: gedit/gedit-encodings-dialog.ui
@@ +48,3 @@
             <property name="is_focus">False</property>
+            <property name="receives_default">True</property>
+            <property name="use_stock">True</property>

Please, set the valign property as center, and also
add the "text-button" style here.
Btw, why set use_stock, is deprecated.

@@ +66,3 @@
+            <property name="receives_default">True</property>
+            <property name="use_stock">True</property>
+            <property name="can_default">True</property>

The same above.

I'd also like a first patch removing the stocks and then do the actual thing, so we can already push the stocks until we make a decision about the headerbars.

Review of attachment 266186 [details] [review]:

::: gedit/gedit-highlight-mode-dialog.ui
@@ +36,3 @@
             <property name="is_focus">False</property>
+            <property name="receives_default">True</property>
+            <property name="use_stock">True</property>

Please, set the valign property as center, and also
add the "text-button" style here.
Btw, why set use_stock, is deprecated.

@@ +54,3 @@
+            <property name="receives_default">True</property>
+            <property name="use_stock">True</property>
+            <property name="can_default">True</property>

The same above.

I want to tackle this before the UI freeze, but I am a little uncertain about some of the issues, so I'll try to make a list and hopefully Jon can shed some light on some of them


1) new prompt style: from what I understood this is beeing punted to 3.14 when there is more time to work out the style of buttons etc

2) file chooser: is the patch still relevant now that gtk picks it up from xsettings? I would really prefer not to have to have conditional win32/osx/gnome code for this

3) document stats: already committed and further tweaked the dialog

4) Prefs dialog: here I really like the idea of using the titlebar since we just need to dismiss the dialog and all the changes are instant apply. There are however two issues with the patch:
  a) do we really want a [Close] button there? I would have simply expected the normal X button
  b) what about the help button? I think it looks fairly bad in the headerbar, but on the other hand the prefs dialog seems one of the places where direct access to contextual documentation is useful

5) Highlight mode: hopefully will move to a popover for this

6) encoding dialog: I guess I'll wait for the filechooser since having one dialog in a way and one in the other is confusing


With regard to the implementation:
1) stock items have already been removed in a separate patch
2) it is not clear to me if Yosef's suggestion still apply or now they are fixed in gtk

So this is all done now except the encoding stuff which needs a more radical redesign.


So current open issues are:

1) The prompt patch has been committed, but looks fairly broken now. We need to check the adwaita side gets actually done, or I would prefer to revert

2) We enabled use-header-bar unconditionally, we may need to get this from the xsetting instead to better integrate some dialogs on other platforms

3) the encoding dialog is lame, needs rethinking

I am closing this for now. 1 and 2 in the last comment seem ok for now, I am sure we'll get bugreports if they become a problem.

I am not opening a separate report for the encodings stuff, because we know it is one of the things needs another UI iteration along with many others, but if you want to file one so that you can track the progress, feel free to do so.


Thanks for the patches!