After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721859 - plugins: do not apply overlay composition in the GLTextureUpload function
plugins: do not apply overlay composition in the GLTextureUpload function
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 719412
 
 
Reported: 2014-01-09 11:59 UTC by Matthieu Bouron
Modified: 2014-01-14 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugins: do not apply overlay composition in the GLTextureUpload function (1.07 KB, patch)
2014-01-09 11:59 UTC, Matthieu Bouron 		none Details | Review

Description Matthieu Bouron 2014-01-09 11:59:04 UTC 
The GLTextureUpload function is not supposed to be in charge of doing the overlay composition if any.
Comment 1 Matthieu Bouron 2014-01-09 11:59:54 UTC 
Created attachment 265828 [details] [review]
plugins: do not apply overlay composition in the GLTextureUpload function
Comment 2 Gwenole Beauchesne 2014-01-13 17:51:21 UTC 
Hi, what about the GstSurfaceMeta::upload() one for GStreamer 1.0? Thanks.

Historically, I uploaded the video overlay into the texture because very few sinks could actually handle the overlay rectangles correctly. What sink do you have in mind?
Comment 3 Matthieu Bouron 2014-01-14 14:51:29 UTC 
(In reply to comment #2)
> Hi, what about the GstSurfaceMeta::upload() one for GStreamer 1.0? Thanks.
> 
> Historically, I uploaded the video overlay into the texture because very few
> sinks could actually handle the overlay rectangles correctly. What sink do you
> have in mind?

cluttersink, see: https://bugzilla.gnome.org/show_bug.cgi?id=721925

As I said i don't think the overlay composition should be done in the upload function because it is not intended to do so and for example you can deal with interlaced images and applying an overlay ontop of fields before any possible deinterlacing is not correct.
Comment 4 Gwenole Beauchesne 2014-01-14 17:59:31 UTC 
I am fine to drop it if sinks implement that instead. As I mentioned, I applied the overlay composition at gst-vaapi level because no GL sink handled that. :)
Comment 5 Gwenole Beauchesne 2014-01-14 18:16:19 UTC 
Applied, thanks.
Comment 6 Gwenole Beauchesne 2014-01-14 18:16:30 UTC 
commit b065ae7d7fb998833f1c44d6e46356e8c5c913b8
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Thu Jan 9 11:54:11 2014 +0000

    plugins: don't apply overlay composition in GLTextureUpload function.
    
    The GLTextureUpload function is not in charge of doing the overlay
    composition if any.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=721859
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>