After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721806 - CSS pseudo-class should have case-insenstive matching
CSS pseudo-class should have case-insenstive matching
Status: RESOLVED WONTFIX
Product: libcroco
Classification: Core
Component: General
0.6
Other All
: Normal minor
: ---
Assigned To: libcroco maintainers
libcroco maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2014-01-08 17:02 UTC by Martin Owens
Modified: 2020-08-11 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch forwarded from Inkscape (770 bytes, patch)
2014-01-09 11:51 UTC, Alex Valavanis 		rejected Details | Review
New version of the patch (778 bytes, patch)
2014-03-25 22:51 UTC, Markus Engel 		none Details | Review

Description Martin Owens 2014-01-08 17:02:21 UTC 
Reporting a bug from inkscape, patched there for the specific case:

https://bugs.launchpad.net/inkscape/+bug/1267118

Summary: When checking the lang pseudo class, libcroco does so in a can sensitive manner using strqcmp which uses a simple memcmp. The css standard requires a case-insensitive comparison instead.
Comment 1 Alex Valavanis 2014-01-09 11:51:49 UTC 
Created attachment 265827 [details] [review]
Patch forwarded from Inkscape
Comment 2 Christian Persch 2014-01-09 13:08:30 UTC 
Comment on attachment 265827 [details] [review]
Patch forwarded from Inkscape

strcasecmp is not the right compare function. Use g_ascii_str[n]casecmp().
Comment 3 Markus Engel 2014-03-25 22:51:01 UTC 
Created attachment 272915 [details] [review]
New version of the patch

I uploaded a new version of the patch that uses g_ascii_strcasecmp() instead.
Comment 4 Alex Valavanis 2014-04-25 10:53:48 UTC 
Hi there,

Has anyone had chance to look at the revised patch?  Would be great to see this fixed.
Comment 5 Alex Valavanis 2014-09-17 14:00:41 UTC 
Hi again,

Just another bump about this small patch. Is anyone willing to review?

Best wishes,


Alex
Comment 6 Alex Valavanis 2015-11-02 12:03:43 UTC 
Hi again,

A year since my last bump... please could someone take a look at this very small patch?

AV
Comment 7 André Klapper 2020-08-11 15:46:26 UTC 
libcroco is not under development anymore. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.