After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721763 - Long channel topics cannot be fully read
Long channel topics cannot be fully read
Status: RESOLVED OBSOLETE
Product: polari
Classification: Applications
Component: general
3.11.x
Other Linux
: Normal minor
: ---
Assigned To: Polari maintainers
Polari maintainers
: 724325 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-01-08 02:37 UTC by Jean-François Fortin Tam
Modified: 2021-06-10 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposal for /topic and other command notifications (17.94 KB, image/png)
2016-09-23 10:04 UTC, Efe Gürkan YALAMAN
  Details
appNotifications: add line wrap for simple notifications (1.26 KB, patch)
2016-09-23 10:26 UTC, Efe Gürkan YALAMAN
committed Details | Review

Description Jean-François Fortin Tam 2014-01-08 02:37:58 UTC
If you join #pitivi on freenode on a small screen width (ex: 1280x*) you may see the topic being ellipsized (truncated) in the headerbar.

A possible solution for this would probably be to show a tooltip on mouseover, containing the full topic string.
Comment 1 Florian Müllner 2014-02-13 23:11:48 UTC
*** Bug 724325 has been marked as a duplicate of this bug. ***
Comment 2 Mateus Rodrigues Costa 2015-06-30 22:37:30 UTC
/topic also doesn't fully show the channel's topic.
Comment 3 Sankaranarayanan Viswanathan 2016-03-29 00:38:28 UTC
Any suggestions on how to fix this? I was trying out a solution where I enabled line wrapping on the notification, and increased the reveal timeout depending on the length (e.g. 7 seconds if length > 100 chars). But, there is still a limit on how big a topic can fit into the notification and it also depends on the size of the chat window too.
Comment 4 Daniel Korostil 2016-03-31 07:58:47 UTC
I expect a popover here. Notifications can be ellipsized.
Comment 5 June C. 2016-04-22 23:41:46 UTC
Couldn't the topic go in the chat log, like timestamps and join/part messages do? Not saying it should be removed from the title-bar, only that it could be shown on the chat log when you first join the channel, and when you type /topic. 

A mouse popover would be nice (though not accessible to keyboard users).
Comment 6 psychoslave 2016-06-15 06:53:15 UTC
A popover would already be better. Now one may even think of some way to make it available as a text-field when selected, just like Web do in its header bar with Page title and URL. This way the interface may even provide a convenient way to  copy it and even change it if the user as enough right. If implemented, don't forget the little downward arrow that show user there's something unfoldable. For keyboard access, ctrl+L would make it coherent with Web (and misc. others brothers) behavior.
Comment 7 Efe Gürkan YALAMAN 2016-09-23 10:04:33 UTC
Created attachment 336151 [details]
Proposal for /topic and other command notifications

I think setting linewrap on for the notifications would be a nice add for this. This way one can see long messages from command notifications which includes /TOPIC. For the header there should be another fix as discussed above.

I can send the patch I have if it makes sense to you.
Comment 8 Florian Müllner 2016-09-23 10:07:10 UTC
(In reply to Efe Gürkan YALAMAN from comment #7)
> I can send the patch I have if it makes sense to you.

Great, please do!
Comment 9 Efe Gürkan YALAMAN 2016-09-23 10:26:12 UTC
Created attachment 336152 [details] [review]
appNotifications: add line wrap for simple notifications

When a command output is too long, they are not readable on smaller screens.
For example when you type /TOPIC command on a channel with a very long topic,
the notification is printed as one line and not readable. Adding lineWrap to
the notification labels properties makes the label printed out as multiple
lines and all of the output is readable this way.
Comment 10 Florian Müllner 2016-09-23 11:02:33 UTC
Review of attachment 336152 [details] [review]:

Just a minor style nit:
The commit message's subject should be capitalized (that is: "addNotifications: Add ...").

(If you have commit rights, just fix this up before pushing; otherwise I can push the commit for you and do the fixup myself)
Comment 11 Efe Gürkan YALAMAN 2016-09-23 11:18:15 UTC
Since I am new to gnome development, I do not have commit rights. I will keep that in mind on next commits I made.
Comment 12 Florian Müllner 2016-09-23 11:32:56 UTC
Comment on attachment 336152 [details] [review]
appNotifications: add line wrap for simple notifications

(In reply to Efe Gürkan YALAMAN from comment #11)
> Since I am new to gnome development ...

Welcome!
Comment 13 André Klapper 2021-06-10 11:04:39 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of Polari, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/polari/-/issues/

Thank you for your understanding and your help.