GNOME Bugzilla – Bug 721757
Save downloaded subtitles in the same directory as the video
Last modified: 2014-04-13 21:52:44 UTC
Created attachment 265618 [details] [review] 0001-opensubtitles-add-download-location-option.patch It would be nice to have an option to download subtitles in the same directory of the video (instead of the default cache directory). Proposed patch as attachment.
This feels like something which shouldn’t have an option: it should always download the subtitles to one place or the other. The user shouldn’t have to specify where for every download. It might make more sense for the subtitles to always be downloaded to the movie’s directory, rather than the cache directory. Bastien, what do you think?
If I recall correctly the selected value is persisted in the preferences. Once the preferred method is selected you can forget about the option unless you want to change it. I agree that it is convenient to always download the subtitles in the directory of the movie but sometimes you don't have the needed permissions (read-only directory). Obviously you could do an automatic fallback but I suppose it may be confusing for the user.
(In reply to comment #2) > If I recall correctly the selected value is persisted in the preferences. Once > the preferred method is selected you can forget about the option unless you > want to change it. My point is that if it’s possible to avoid making the user set the option in the first place, that would be preferable, IMO. > I agree that it is convenient to always download the subtitles in the directory > of the movie but sometimes you don't have the needed permissions (read-only > directory). > Obviously you could do an automatic fallback but I suppose it may be confusing > for the user. How about asking the user where to save them if the subtitles can’t be saved in the movie’s directory? I guess the main use case here is a read-only NAS or UPnP device, which the user probably plays a lot of movies from, so having a ‘always save subtitles in this directory in future’ checkbox in the save dialogue would make sense. Out of interest, what’s your use case for accessing the subtitle files in the first place? Just want to check that we’re solving the right basic problem here.
I think it should be automatic. If you're downloading a subtitle, try to save it to the video's directory and if it fails, save it in ~/.cache/totem/subtitles.
Comment on attachment 265618 [details] [review] 0001-opensubtitles-add-download-location-option.patch Marking as needs-work based on the last comment.
Yes, please keep the downloaded along with the video files. SMplayer does this very well.
Created attachment 274114 [details] [review] opensubtitles: Save downloaded subtitles in the video directory Try to download the subtitle to the movie's directory, and to the cache directory if it fails (read-only locations)
Comment on attachment 274114 [details] [review] opensubtitles: Save downloaded subtitles in the video directory Pushed in commit b78d307a6832d9198e8eecac1c24e13a85be7b16