After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721741 - The positions of the buttons in the headerbar is wrong
The positions of the buttons in the headerbar is wrong
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
3.12
: 724666 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-01-07 21:47 UTC by Yosef Or Boczko
Modified: 2014-02-20 09:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
headerbar: Fix item positions (4.96 KB, patch)
2014-01-07 21:47 UTC, Yosef Or Boczko 		needs-work Details | Review
headerbar: Fix item positions (1.55 KB, patch)
2014-02-01 23:16 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2014-01-07 21:47:21 UTC 
After the following commit in gtk+, the positions of the buttons
in the headerbar is wrong:
https://git.gnome.org/browse/gtk+/commit/?id=c3e91c70317b337c72282a1aad68fc82a82bf9e9
Comment 1 Yosef Or Boczko 2014-01-07 21:47:50 UTC 
Created attachment 265595 [details] [review]
headerbar: Fix item positions
Comment 2 Vadim Rutkovsky 2014-01-08 17:24:40 UTC 
Review of attachment 265595 [details] [review]:

This breaks buttons display on 3.8/3.10, so we either should find a universal way or master should be built without 3.8/3.10 compatibility
Comment 3 Vadim Rutkovsky 2014-01-08 17:35:36 UTC 
As we've discussed in IRC, another option is porting to GtkBox, which seems to be the best one
Comment 4 Yosef Or Boczko 2014-02-01 23:16:20 UTC 
Created attachment 267810 [details] [review]
headerbar: Fix item positions
Comment 5 Allan Day 2014-02-06 14:10:47 UTC 
I tested the patch and it works as intended. The search button seems to be 1px taller than the selection mode one... don't know if that's related to this or not.
Comment 6 Allan Day 2014-02-06 14:12:49 UTC 
(In reply to comment #5)
> I tested the patch and it works as intended. ...

Actually, no it doesn't - the view switcher is missing.
Comment 7 Vadim Rutkovsky 2014-02-10 14:06:01 UTC 
Attachment 267810 [details] pushed as 75f4a0b - headerbar: Fix item positions
Comment 8 Vadim Rutkovsky 2014-02-10 14:21:16 UTC 
Fixed in https://git.gnome.org/browse/gnome-music/commit/?id=75f4a0b (view switcher appeared correctly for me)
Comment 9 Vadim Rutkovsky 2014-02-20 09:39:09 UTC 
*** Bug 724666 has been marked as a duplicate of this bug. ***