GNOME Bugzilla – Bug 721381
Doesn't keep flags when moving messages
Last modified: 2014-01-15 02:01:25 UTC
Description of problem: If an e-mail is received via EWS and is then read or replied to and then quickly moved into another folder, depending on the time that passed, the flags will not be kept (read, replied etc.). In other words, a read e-mail will become unread when moved to a different folder, unless (I'm guessing) sufficient time is given to Evo to sync the back end. Version-Release number of selected component (if applicable): evolution-ews-3.10.3-1.fc20.i686 How reproducible: Sometimes (depends on the time given to evo to commit changes to back end). Steps to Reproduce: 1. Receive and e-mail, read it in preview. 2. Move it to another folder. 3. Becomes unread. Actual results: Message flags are not being preserved. Expected results: Should work just like with other backends. So, sync first, then move.
Created attachment 265535 [details] [review] Bug #721381 - Evolution EWS doesn't keep flags when moving messages
Review of attachment 265535 [details] [review]: Untested, but basically looks fine. See the only one comment I have. ::: src/camel/camel-ews-folder.c @@ +1699,3 @@ + + if (mi_list_len == EWS_MAX_FETCH_COUNT) { + success = ews_sync_mi_flags (source, mi_list, cancellable, &local_error); if this fails, or is cancelled, then you ignore/overwrite the success value if there are 2*EWS_MAX_FETCH_COUNT uids in the list; you also do not do the same test on the local_error as below (it feels like a good candidate to provide it as a function, to not write the same comment and code on three places).
Created attachment 266244 [details] [review] Bug #721381 - Evolution EWS doesn't keep flags when moving messages
Review of attachment 266244 [details] [review]: Untested, but looks good, please commit to sources, you can both stable and master.
Pushed! stable: 8f567b48 (3.10.4+) master: e22b13ec (3.11.5+)