After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721119 - GtkMenuTracker: tweak separator logic
GtkMenuTracker: tweak separator logic
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkApplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-12-27 07:08 UTC by Allison Karlitskaya (desrt)
Modified: 2014-01-04 23:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkMenuTracker: tweak separator logic (2.07 KB, patch)
2013-12-27 07:08 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2013-12-27 07:08:56 UTC
Ignacio Casal Quinteiro reported a problem whereby an empty section at
the start of a menu has a separator placed after it.  This was caused by
the implementation of the logic that separators should be inserted at
the top of all non-empty sections that are not the first section.  This
logic is obviously incorrect in the case that the first section is empty
(in which case we would not expect to see a separator at the top of the
second section).

Change the logic so that we only insert separators when we see a
non-zero number of actual items in the menu before us.
Comment 1 Allison Karlitskaya (desrt) 2013-12-27 07:08:58 UTC
Created attachment 264923 [details] [review]
GtkMenuTracker: tweak separator logic
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-12-27 07:38:14 UTC
It works for me.
Comment 3 Allison Karlitskaya (desrt) 2014-01-04 07:31:57 UTC
Attachment 264923 [details] pushed as ba09124 - GtkMenuTracker: tweak separator logic
Comment 4 Ignacio Casal Quinteiro (nacho) 2014-01-04 23:22:51 UTC
Thanks a lot!