GNOME Bugzilla – Bug 721097
Include colon in translatable string instead of concatenating
Last modified: 2014-08-17 10:02:31 UTC
Hello, In Ubuntu 13.10, the Ubuntu Software Center version is 3.5.0. The string " Example Path " should include the " : " so in French we could add the unbreakable space after the last letter as we have to. So the string to translate should be " Example Path: " Thank you for your work
Easy to fix in https://git.gnome.org/browse/sound-juicer/tree/src/sj-prefs.c#n306 by moving the colon one line higher (Note that this would break any string freezes though): format = g_strconcat ("<small><i><b>", _("Example Path"), ":</b> ", example, ".", rb_gst_media_type_to_extension (media_type), "</i></small>", NULL);
sound-juicer is not really following gnome release schedule, so I'd tend to say it's not impacted by the freezes. Could you push what you suggest André?
Created attachment 277371 [details] [review] Patch for Bug 720197 I am new to open source. I had tried to read the code and created a patch. I don't know if its correct or not. If not, please help me over this.
Review of attachment 277371 [details] [review]: The patch looks mostly fine, but your commit message needs to: - explain what problems this fixes (in the first line, the "Subject" line - explain how you did it (in the body of the commit message) - link to the bug report (put the full URL at the bottom of the commit message) Good first contribution! :) ::: src/sj-prefs.c @@ +310,3 @@ format = g_strconcat ("<small><i><b>", + _("Example Path: "), + "</b>", Indentation is broken now.
> Indentation is broken now. Please make sure you indent your code with spaces rather than tabs to avoid this.
I've fixed this patch and pushed it for ready for the next release. Attachment 277371 [details] edited and pushed as a83066d - Include colon in translatable string