GNOME Bugzilla – Bug 720835
video-sink: add deinterlacing support to the GLTextureUploadRenderer
Last modified: 2021-05-25 17:32:53 UTC
This patch applies on top of the 2.0.8 + gltextureupload patches and adds deinterlacing support to the GLTextureUploadRenderer. This is useful with the current playbin situation (no support of hardware deinterlacer yet) when an hardware decoder is plugged and the output is interlaced. The method implemented here is based on what is done in the gldeinterlace element and use the greedy high motion algorithm.
Created attachment 264623 [details] [review] video-sink: add deinterlacing support to the GLTextureUploadRenderer
You're putting like 6 branches in a fragment shader. That's going to have a cost... Wouldn't it be simpler to use some geometry instead? Basically one line from each texture?
Created attachment 265910 [details] [review] video-sink: add deinterlacing support to the GLTextureUploadRenderer Patch rebased on top of this development branch including the composition overlay rendering feature: http://cgit.collabora.com/git/user/mateo/clutter-gst.git/log/?h=clutter-gst-2.0/deinterlace-overlay-gltextureuploadrenderer
Created attachment 266493 [details] [review] video-sink: add deinterlacing support to the GLTextureUploadRenderer Fixes a material leak.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/clutter-gst/-/issues/ Thank you for your understanding and your help.