After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720835 - video-sink: add deinterlacing support to the GLTextureUploadRenderer
video-sink: add deinterlacing support to the GLTextureUploadRenderer
Status: RESOLVED OBSOLETE
Product: clutter-gst
Classification: Other
Component: general
2.0.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on: 721925
Blocks:
 
 
Reported: 2013-12-20 15:49 UTC by Matthieu Bouron
Modified: 2021-05-25 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
video-sink: add deinterlacing support to the GLTextureUploadRenderer (11.84 KB, patch)
2013-12-20 15:51 UTC, Matthieu Bouron
none Details | Review
video-sink: add deinterlacing support to the GLTextureUploadRenderer (10.12 KB, patch)
2014-01-10 11:43 UTC, Matthieu Bouron
none Details | Review
video-sink: add deinterlacing support to the GLTextureUploadRenderer (10.15 KB, patch)
2014-01-16 17:11 UTC, Matthieu Bouron
none Details | Review

Description Matthieu Bouron 2013-12-20 15:49:51 UTC
This patch applies on top of the 2.0.8 + gltextureupload patches and adds deinterlacing support to the GLTextureUploadRenderer.
This is useful with the current playbin situation (no support of hardware deinterlacer yet) when an hardware decoder is plugged and the output is interlaced.

The method implemented here is based on what is done in the gldeinterlace element and use the greedy high motion algorithm.
Comment 1 Matthieu Bouron 2013-12-20 15:51:44 UTC
Created attachment 264623 [details] [review]
video-sink: add deinterlacing support to the GLTextureUploadRenderer
Comment 2 Lionel Landwerlin 2013-12-23 11:18:54 UTC
You're putting like 6 branches in a fragment shader. That's going to have a cost...
Wouldn't it be simpler to use some geometry instead? Basically one line from each texture?
Comment 3 Matthieu Bouron 2014-01-10 11:43:00 UTC
Created attachment 265910 [details] [review]
video-sink: add deinterlacing support to the GLTextureUploadRenderer

Patch rebased on top of this development branch including the composition overlay rendering feature: http://cgit.collabora.com/git/user/mateo/clutter-gst.git/log/?h=clutter-gst-2.0/deinterlace-overlay-gltextureuploadrenderer
Comment 4 Matthieu Bouron 2014-01-16 17:11:08 UTC
Created attachment 266493 [details] [review]
video-sink: add deinterlacing support to the GLTextureUploadRenderer

Fixes a material leak.
Comment 5 André Klapper 2021-05-25 17:32:53 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new enhancement request ticket at
  https://gitlab.gnome.org/GNOME/clutter-gst/-/issues/

Thank you for your understanding and your help.