After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720737 - vaapisink: add system memory caps to template caps
vaapisink: add system memory caps to template caps
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 719412
 
 
Reported: 2013-12-19 12:08 UTC by Gwenole Beauchesne
Modified: 2014-01-15 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
expose the raw video formats in static caps template (1.19 KB, patch)
2013-12-19 12:09 UTC, Gwenole Beauchesne
none Details | Review

Description Gwenole Beauchesne 2013-12-19 12:08:19 UTC
This is a follow-up to bug #703271. Since vaapisink supports raw YUV buffers, then this must be signalled in the static templates too. Next, the CAPS query will make it possible to fine tune the exact set of supported formats.
Comment 1 Gwenole Beauchesne 2013-12-19 12:09:34 UTC
Created attachment 264537 [details] [review]
expose the raw video formats in static caps template

Expose all raw video formats in the static caps template since the
vaapisink is supporting raw data. We will get the exact set of formats
supported by the driver dynamically through the _get_caps() routine.
Comment 2 Gwenole Beauchesne 2013-12-19 12:10:54 UTC
Per previous comment, gst_vaapisink_get_caps_impl() needs some arrangements to avoid duplicates from the template pad caps. e.g. remove formats from what we get from the template pad caps, or don't actually use gst_static_pad_template_get_caps() but rather build clean caps that only mention the first series for caps with memory:VASurface feature.
Comment 3 Gwenole Beauchesne 2014-01-15 10:27:09 UTC
commit dd6751ed47c8c7c2d69c25cbeb2d064d8fa96d66
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Wed Oct 9 13:47:54 2013 +0300

    vaapisink: expose the raw video formats in static caps template.
    
    Expose all raw video formats in the static caps template since the
    vaapisink is supporting raw data. We will get the exact set of formats
    supported by the driver dynamically through the _get_caps() routine.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=703271
    https://bugzilla.gnome.org/show_bug.cgi?id=720737
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>