After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720734 - Show anonymous avatar by default
Show anonymous avatar by default
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other All
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-19 11:34 UTC by Techlive Zheng
Modified: 2014-07-01 09:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show anonymous avatar by default (3.40 KB, patch)
2013-12-19 11:34 UTC, Techlive Zheng 		none Details | Review
Fix round corner on the right side (750 bytes, patch)
2013-12-21 17:12 UTC, Techlive Zheng 		accepted-commit_now Details | Review
Use GNOME's default avatar (7.91 KB, patch)
2013-12-23 14:26 UTC, Techlive Zheng 		none Details | Review

Description Techlive Zheng 2013-12-19 11:34:19 UTC 
Incase of there is no network available.
Comment 1 Techlive Zheng 2013-12-19 11:34:21 UTC 
Created attachment 264530 [details] [review]
Show anonymous avatar by default
Comment 2 Techlive Zheng 2013-12-21 17:08:49 UTC 
See branch wip/techlivezh/use-default-avatar
Comment 3 Techlive Zheng 2013-12-21 17:12:44 UTC 
Created attachment 264718 [details] [review]
Fix round corner on the right side
Comment 4 jessevdk@gmail.com 2013-12-23 09:21:26 UTC 
Review of attachment 264530 [details] [review]:

Where did this avatar.png come from? Also, it's missing in the patch.
Comment 5 jessevdk@gmail.com 2013-12-23 09:22:04 UTC 
Review of attachment 264718 [details] [review]:

Looks good
Comment 6 Techlive Zheng 2013-12-23 09:58:24 UTC 
(In reply to comment #4)
> Review of attachment 264530 [details] [review]:
> 
> Where did this avatar.png come from? Also, it's missing in the patch.

http://1.gravatar.com/avatar/ad516503a11cd5ca435acc9bb6523536?s=50

Should be free to use.
Comment 7 Techlive Zheng 2013-12-23 09:59:04 UTC 
Fixed in commit 24a1a86.
Comment 8 jessevdk@gmail.com 2013-12-23 10:35:53 UTC 
I think there is a gnome avatar icon, we should probably use that. for example, I have /usr/share/icons/gnome/scalable/status/avatar-default-symbolic.svg.
Comment 9 jessevdk@gmail.com 2013-12-23 10:37:11 UTC 
Also, I didn't sign off yet on the avatar patch. Try to commit just the stuff that has been marked accepted-commit_now, otherwise the review process becomes a bit obsolete :)
Comment 10 Techlive Zheng 2013-12-23 11:08:50 UTC 
(In reply to comment #9)
> Also, I didn't sign off yet on the avatar patch. Try to commit just the stuff
> that has been marked accepted-commit_now, otherwise the review process becomes
> a bit obsolete :)

Soryy, I thought this was okay to push, my bad.
Comment 11 Techlive Zheng 2013-12-23 11:10:27 UTC 
(In reply to comment #8)
> I think there is a gnome avatar icon, we should probably use that. for example,
> I have /usr/share/icons/gnome/scalable/status/avatar-default-symbolic.svg.

I do not have that, if it is from GNOME, We probably should use it.
Comment 12 jessevdk@gmail.com 2013-12-23 11:47:07 UTC 
It's in gnome-icon-theme-symbolic: https://git.gnome.org/browse/gnome-icon-theme-symbolic/plain/gnome/scalable/status/avatar-default-symbolic.svg
Comment 13 Techlive Zheng 2013-12-23 14:26:17 UTC 
Created attachment 264800 [details] [review]
Use GNOME's default avatar
Comment 14 jessevdk@gmail.com 2014-06-26 07:17:43 UTC 
It would be great if we didn't provide the avatar image ourselves, but took it from the system theme. It shouldn't be too hard to do.
Comment 15 jessevdk@gmail.com 2014-07-01 09:04:16 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.