After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720730 - vaapipostproc: add support for GstVideoCropMeta
vaapipostproc: add support for GstVideoCropMeta
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 720305
 
 
Reported: 2013-12-19 10:34 UTC by Gwenole Beauchesne
Modified: 2014-06-18 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Gwenole Beauchesne 2013-12-19 10:34:33 UTC 
Add support for video cropping. If the sink buffer has GstVideoCropMeta, it needs to be applied into the resulting output buffer if pass-through mode is not used. By pass-through, I also include buffers that are propagated downstream as is but only changing rendering flags like top/bottom field flags.

i.e. use gst_vaapi_filter_set_cropping_rectangle() if GstVideoCropMeta is present. This is for GStreamer >= 1.0. For older GStreamer 0.10, I have no special requirement, but supporting it looks simple too, since we have that information stored in the GstVaapiSurfaceProxy.
Comment 1 Gwenole Beauchesne 2014-06-18 14:26:05 UTC 
commit b3401dbb294eac4bd91d8d92c1f1ecafe72d8c59
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Wed Jun 18 16:16:34 2014 +0200

    vaapipostproc: add support for crop regions in VPP mode.
    
    Apply video cropping regions stored in GstVideoCropMeta, or in older
    GstVaapiSurfaceProxy representation, to VPP pipelines. In non-VPP modes,
    the crop meta are already propagated to the output buffers.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720730