GNOME Bugzilla – Bug 720698
Add an app folder setting
Last modified: 2014-01-10 19:42:01 UTC
This setting is needed for gnome-shell and gnome-software to communicate about application folders, which are configured in gnome-software and displayed in gnome-shell.
Created attachment 264500 [details] [review] Add an app folder setting
Review of attachment 264500 [details] [review]: Wouldn't it be better to have child schemas? Make the folders contain a list of "folder names" which would also be identifiers for the various schemas.
(In reply to comment #2) > Wouldn't it be better to have child schemas? Make the folders contain a list of > "folder names" which would also be identifiers for the various schemas. We do not support arbitrary nesting of folders.
(In reply to comment #3) > (In reply to comment #2) > > Wouldn't it be better to have child schemas? Make the folders contain a list of > > "folder names" which would also be identifiers for the various schemas. > > We do not support arbitrary nesting of folders. That doesn't matter. The folders settings contains a list of GSettings paths to children. Each child would contain a key that enumerates the desktop files you want in your folder, another key is the folder name. That means that you don't have to rewrite all the folders when you change the name of a single one, and you can easily add more metadata without breaking existing configurations. See what the wacom plugin uses in g-s-d: https://git.gnome.org/browse/gnome-settings-daemon/tree/data/org.gnome.settings-daemon.peripherals.wacom.gschema.xml.in.in
hmm, I can't say I'm very interested in rewriting this. There is really no need to optimize this for localized changes, as far as I can see - there's only going to be a handful of folders, each containing at most a screenful of apps.
This implementation would break the day we choose to implement live app folders editing in gnome-shell, or if we want to setup locked down folders. So I'm not going to accept that implementation.
(In reply to comment #6) > This implementation would break the day we choose to implement live app folders > editing in gnome-shell Why?
(In reply to comment #7) > (In reply to comment #6) > > This implementation would break the day we choose to implement live app folders > > editing in gnome-shell > > Why? Because you'd be modifying all the folders' definitions by changing a single one. It's also terribly inefficient.
Created attachment 265904 [details] [review] Add an app folder setting This schema is needed for gnome-shell and gnome-software to communicate about application folders, which are configured in gnome-software and displayed in gnome-shell.
Created attachment 265905 [details] [review] gnome-software patch
Review of attachment 265904 [details] [review]: Excellent.
Review of attachment 265905 [details] [review]: ::: data/org.gnome.software.gschema.xml @@ -19,3 @@ <summary>The last update timestamp</summary> </key> - <key name="app-folders" type="a{sas}"> Why does this schema still exist? Shouldn't we delete this, now that it's in gsettings-desktop-schemas?
yeah, will do when I push the patch
Attachment 265904 [details] pushed as 207d474 - Add an app folder setting