After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720686 - libtracker-extract: Link against libicu when using it
libtracker-extract: Link against libicu when using it
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Extractor
0.17.x
Other Linux
: Normal normal
: ---
Assigned To: tracker-extractor
Depends on:
Blocks:
 
 
Reported: 2013-12-18 16:23 UTC by Debarshi Ray
Modified: 2013-12-18 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libtracker-extract: Link against libicu when using it (2.00 KB, patch)
2013-12-18 16:24 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-12-18 16:23:19 UTC 
... otherwise the build fails.
Comment 1 Debarshi Ray 2013-12-18 16:24:29 UTC 
Created attachment 264489 [details] [review]
libtracker-extract: Link against libicu when using it
Comment 2 Debarshi Ray 2013-12-18 16:25:46 UTC 
This is a fallout from:

commit 86302c3bfce0d3be9a647bbf8b33075916efb8e9
Author: Carlos Garnacho <carlos@lanedo.com>
Date:   Tue Oct 1 12:04:40 2013 +0200

    libtracker-extract: Add ICU-based encoding detection
    
    This is used before enca if libicu is available, an UCharsetDetector
    is used to detect the most likely encoding for a given string. Out
    of testing, it provides more reliable values than enca, where you
    first have to make a rough guess on the locale, yielding more false
    positives.
Comment 3 Carlos Garnacho 2013-12-18 16:36:38 UTC 
Comment on attachment 264489 [details] [review]
libtracker-extract: Link against libicu when using it

Hmm, I wonder how it links alright here... please commit
Comment 4 Debarshi Ray 2013-12-18 16:43:56 UTC 
(In reply to comment #3)
> (From update of attachment 264489 [details] [review])
> Hmm, I wonder how it links alright here... please commit

It also links for me when I build straight out of Git. But rpmbuild complains.
Comment 5 Debarshi Ray 2013-12-18 16:44:16 UTC 
Comment on attachment 264489 [details] [review]
libtracker-extract: Link against libicu when using it

Thanks for the review. Pushed to master.