After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720585 - Glade 3.16 changes the ordering of toolbar size properties, making inline toolbars show up big in GTK 3.10
Glade 3.16 changes the ordering of toolbar size properties, making inline too...
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks: 682886
 
 
Reported: 2013-12-17 04:42 UTC by Jean-François Fortin Tam
Modified: 2013-12-17 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot - before (56.59 KB, image/png)
2013-12-17 04:49 UTC, Jean-François Fortin Tam
Details
screenshot - after (58.07 KB, image/png)
2013-12-17 04:50 UTC, Jean-François Fortin Tam
Details

Description Jean-François Fortin Tam 2013-12-17 04:42:33 UTC
Let's say I have the following as part of a .ui file:


  <object class="GtkToolbar" id="medialibrary_toolbar">
    <property name="visible">True</property>
    <property name="can_focus">False</property>
    <property name="show_arrow">False</property>
    <property name="icon_size">1</property>
    <child internal-child="accessible">
      <object class="AtkObject" id="medialibrary_toolbar-atkobject">
        <property name="AtkObject::accessible-name">foo</property>
      </object>
    </child>


If I open the file with glade 3.16 and save it, it will reorder a bunch of stuff around in the file, and this part in particular will become:


  <object class="GtkToolbar" id="medialibrary_toolbar">
    <property name="visible">True</property>
    <property name="can_focus">False</property>
    <property name="show_arrow">False</property>
    <child internal-child="accessible">
      <object class="AtkObject" id="medialibrary_toolbar-atkobject">
        <property name="AtkObject::accessible-name">foo</property>
      </object>
    </child>
    <property name="icon_size">1</property>


And the problem is that with a toolbar widget using the "inline" style, the toolbar will appear blown up in size with huge buttons and fuzzy icons.
Comment 1 Jean-François Fortin Tam 2013-12-17 04:49:48 UTC
Created attachment 264387 [details]
screenshot - before
Comment 2 Jean-François Fortin Tam 2013-12-17 04:50:07 UTC
Created attachment 264388 [details]
screenshot - after
Comment 3 Tristan Van Berkom 2013-12-17 09:17:37 UTC
Eeek, that's a bad regression. Thanks for reporting it !

Fixed in master as:

commit dec1d5f838f9732d765939fb54b3b1e50f58fdbc
Author: Tristan Van Berkom <tristan@upstairslabs.com>
Date:   Tue Dec 17 18:05:50 2013 +0900

    Bug 720585 - Fix order of customized property output.

And back ported to 3.16 branch

Also updated the bundle here, in case you need the fix quickly ;-)
   https://people.gnome.org/~tvb/test-bundles/glade