GNOME Bugzilla – Bug 720533
Large icons in the list view
Last modified: 2014-02-05 17:01:56 UTC
Created attachment 264291 [details] screenshot Some items have very large icons in the documents list - around 120x120px. It looks bad.
Thankfully not a regression. This has been around for a while -- atleast since F19 / 3.8 days. It only happens when you switch from the grid to the list view while the application is running. Does not happen if you start it in list mode.
Created attachment 264846 [details] [review] documents: Having a thumbPath does not mean thumbnailing had succeeded
Created attachment 264847 [details] [review] documents: Add debug messages for failing to use a thumbnail file
Review of attachment 264847 [details] [review]: Looks good
Review of attachment 264846 [details] [review]: I'd rather we cleared out the thumbnail path entirely if we failed to thumbnail. At least that's what other code assumes if I remember correctly. Maybe we could also take this as an occasion to clean up that code and use the newly introduced G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID feature in GIO?
(In reply to comment #5) > Review of attachment 264846 [details] [review]: > > I'd rather we cleared out the thumbnail path entirely if we failed to > thumbnail. At least that's what other code assumes if I remember correctly. Ok > Maybe we could also take this as an occasion to clean up that code and use the > newly introduced G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID feature in GIO? Ofcourse, but I want to do it in a separate patch so that I can backport the fix to older releases.
Created attachment 268171 [details] [review] documents: Clear the thumbnail path if the thumbnail is invalid
Created attachment 268174 [details] [review] documents: Reduce the number of thumbnailing invariants A little cleanup.
Review of attachment 268174 [details] [review]: OK
Review of attachment 268171 [details] [review]: This looks good to me too. I wonder if shouldn't record the fact that we failed to thumbnail this specific document somewhere, to avoid retrying ad-infinitum later, but it's probably OK for now.
(In reply to comment #10) > Review of attachment 268171 [details] [review]: > > I wonder if shouldn't record the fact that we failed > to thumbnail this specific document somewhere, to avoid retrying ad-infinitum refreshIcon already looks at this._failedThumbnailing and bails out if it had failed before. Or did you mean something else?
Comment on attachment 268171 [details] [review] documents: Clear the thumbnail path if the thumbnail is invalid Thanks for the review!
Let's use a separate bug for G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID and further improvements. This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.