After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720512 - flacparse: Doesn't set the codec tag
flacparse: Doesn't set the codec tag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.2.0
Other All
: Normal minor
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-15 22:58 UTC by Richard Röjfors
Modified: 2013-12-16 09:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch solving the issue (1.80 KB, patch)
2013-12-15 22:58 UTC, Richard Röjfors 		committed Details | Review

Description Richard Röjfors 2013-12-15 22:58:22 UTC 
Created attachment 264255 [details] [review]
Patch solving the issue

The attached patch sets the audio tag in a similar way
as done in the gstmpegaudioparse.
Comment 1 Sebastian Dröge (slomo) 2013-12-16 09:04:25 UTC 
Pushed a slightly different version that uses the pbutils API to generate the string for the codec tag.

commit 2927805749393bc90647dc24cf8f13cba4640850
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 16 10:02:37 2013 +0100

    wavpackparse: Post AUDIO_CODEC tag

commit 753d3c23a21db76f2d13d4378fd911e6da211bd1
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 16 10:00:37 2013 +0100

    sbcparse: Post AUDIO_CODEC tag

commit 05e196cbb62848d9cc72b14249e4b0316fd3fdd5
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 16 09:58:31 2013 +0100

    flacparse: Post AUDIO_CODEC tag
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720512

commit 29f2cae129c84ac3159a350b991050b0937f201d
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 16 09:56:29 2013 +0100

    dcaparse: Post AUDIO_CODEC tag

commit d2ab5199bcd3da6424d64064dc6f77e65d47c674
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 16 09:54:38 2013 +0100

    amrparse: Post AUDIO_CODEC tag

commit 6f89b430ea9f85dc4f46396402b5910a72750565
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 16 09:49:48 2013 +0100

    ac3parse: Post AUDIO_CODEC tag

commit b3abbe3f5ec42c5c654e6d634c016f764aebc5ff
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 16 09:46:16 2013 +0100

    aacparse: Post AUDIO_CODEC tag

commit c07424a534cb59b4e47065d894fba5dcd47191c8
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 16 09:41:14 2013 +0100

    mpegaudioparse: Use pbutils functionality to create the AUDIO_CODEC tag