After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720287 - cogl-path: Export cogl_clip_push_from_path
cogl-path: Export cogl_clip_push_from_path
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-11 20:58 UTC by Colin Walters
Modified: 2013-12-11 22:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cogl-path: Export cogl_clip_push_from_path (1002 bytes, patch)
2013-12-11 20:58 UTC, Colin Walters
none Details | Review

Description Colin Walters 2013-12-11 20:58:20 UTC
It's needed by clutter; fixes the build of current Continuous.
Comment 1 Colin Walters 2013-12-11 20:58:22 UTC
Created attachment 264010 [details] [review]
cogl-path: Export cogl_clip_push_from_path
Comment 2 Ray Strode [halfline] 2013-12-11 21:00:54 UTC
Review of attachment 264010 [details] [review]:

::: cogl-path/Makefile.am
@@ +80,3 @@
 libcogl_path_la_LDFLAGS = \
 	-export-dynamic \
+	-export-symbols-regex "^(cogl|cogl2)_(framebuffer|path|is|clip)_.*" \

imo, should probably just be "^cogl.*"

There's no real advantage to being less liberal here is there?
Comment 3 Robert Bragg 2013-12-11 22:12:42 UTC
Yeah, this is pretty silly. I've just pushed Colin's patch for now and I'll follow up with a patch to simplify it as you suggested. thanks.