After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720239 - Add a way to manage form passwords
Add a way to manage form passwords
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 624638 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-12-11 08:57 UTC by William Jon McCann
Modified: 2013-12-11 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a new passwords dialog (37.68 KB, patch)
2013-12-11 08:57 UTC, William Jon McCann 		committed Details | Review
Add a popup menu to copy username and password (7.12 KB, patch)
2013-12-11 08:57 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2013-12-11 08:57:52 UTC 
We currently don't have any way to manage saved form passwords - only
http auth ones. This adds that capability.
Comment 1 William Jon McCann 2013-12-11 08:57:54 UTC 
Created attachment 263967 [details] [review]
Add a new passwords dialog
Comment 2 William Jon McCann 2013-12-11 08:57:57 UTC 
Created attachment 263968 [details] [review]
Add a popup menu to copy username and password
Comment 3 William Jon McCann 2013-12-11 11:59:29 UTC 
*** Bug 624638 has been marked as a duplicate of this bug. ***
Comment 4 Claudio Saavedra 2013-12-11 14:01:34 UTC 
Review of attachment 263967 [details] [review]:

I think those two things need fixing, otherwise looks good!

::: src/passwords-dialog.c
@@ +355,3 @@
+		attributes = secret_item_get_attributes (item);
+		username = g_hash_table_lookup (attributes, USERNAME_KEY);
+		host = ephy_string_get_host_name (g_hash_table_lookup (attributes, URI_KEY));

This is leaked.

@@ +423,3 @@
+	if (host != NULL && g_strrstr (host, dialog->priv->search_text) != NULL)
+		visible = TRUE;
+	if (username != NULL && g_strrstr (username, dialog->priv->search_text) != NULL)

else if?
Comment 5 Claudio Saavedra 2013-12-11 14:05:06 UTC 
Review of attachment 263968 [details] [review]:

Looks good. I would probably refactor a bit but I don't want to stop you from pushing before you leave!
Comment 6 William Jon McCann 2013-12-11 14:26:23 UTC 
Attachment 263967 [details] pushed as 114f45f - Add a new passwords dialog
Attachment 263968 [details] pushed as ffc391d - Add a popup menu to copy username and password