After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719973 - orientation plugin: unset source ID when the idle is removed
orientation plugin: unset source ID when the idle is removed
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-06 14:04 UTC by Carlos Garnacho
Modified: 2013-12-10 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
orientation: Unset source ID on idle callback (1.82 KB, patch)
2013-12-06 14:05 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2013-12-06 14:04:30 UTC 
The idle to start the orientation plugin features isn't set to 0 after initialization, causing warnings on shutdown. I'm attaching a patch to fix this
Comment 1 Carlos Garnacho 2013-12-06 14:05:11 UTC 
Created attachment 263669 [details] [review]
orientation: Unset source ID on idle callback

The idle was being removed, but the source ID was left != 0, so on
shutdown it'd cause warnings.
Comment 2 Bastien Nocera 2013-12-10 10:58:42 UTC 
Review of attachment 263669 [details] [review]:

Can you please split this in 2 patches (one for the bug fix, one for the helper change)? Looks good otherwise
Comment 3 Carlos Garnacho 2013-12-10 12:55:35 UTC 
I've committed those separately to master