After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719724 - wayland: Set the clutter stage focus when we focus a window
wayland: Set the clutter stage focus when we focus a window
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-02 21:40 UTC by Rui Matos
Modified: 2013-12-03 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Set the clutter stage focus when we focus a window (1.27 KB, patch)
2013-12-02 21:40 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-12-02 21:40:16 UTC 
This fixes window keybindings like Alt+F10 to toggle maximize.
Comment 1 Rui Matos 2013-12-02 21:40:19 UTC 
Created attachment 263341 [details] [review]
wayland: Set the clutter stage focus when we focus a window

Otherwise clutter events don't have their source actor properly set
and we aren't able to determine the MetaWindow to which a given
keybinding applies.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-12-02 22:27:17 UTC 
Review of attachment 263341 [details] [review]:

I just want to be careful that this won't confuse the actor/window tracking in gnome-shell (perhaps we need some carefully placed meta_is_wayland_compositor tests), but otherwise it looks fine.
Comment 3 Rui Matos 2013-12-03 16:18:54 UTC 
(In reply to comment #2)
> I just want to be careful that this won't confuse the actor/window tracking in
> gnome-shell (perhaps we need some carefully placed meta_is_wayland_compositor
> tests), but otherwise it looks fine.

I think it shouldn't be a problem because either
meta_display_process_key_event() or
meta_wayland_compositor_handle_event() should consume the event away
from clutter event processing before it ever reaches actors managed by
gnome-shell.

Attachment 263341 [details] pushed as 20e92c5 - wayland: Set the clutter stage focus when we focus a window