After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719670 - x264enc: option-string are applied before other gstreamer properties
x264enc: option-string are applied before other gstreamer properties
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-02 02:09 UTC by Matej Knopp
Modified: 2016-02-21 22:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to apply option-string (option_string_prop) after gstreamer option string (1.88 KB, patch)
2013-12-02 02:09 UTC, Matej Knopp 		none Details | Review

Description Matej Knopp 2013-12-02 02:09:28 UTC 
Created attachment 263265 [details] [review]
Patch to apply option-string (option_string_prop) after gstreamer option string

Happens contrary to the property documentation so option-string won't override gstreamer option string. Might be because encoder->option_string_prop and encoder->option_string are a bit confusing.
Comment 1 Tim-Philipp Müller 2013-12-02 20:53:32 UTC 
Contrary to which documentation?

I would read

 option-string       : String of x264 options (overridden by element properties)

as "option_string will override option_string_prop". Same for: 

 * If a preset/tuning are specified then these will define the default values and
 * the property defaults will be ignored. After this the option-string property is
 * applied, followed by the user-set properties, fast first pass restrictions and
 * finally the profile restrictions.
Comment 2 Matej Knopp 2013-12-02 23:26:35 UTC 
I must have misread it then. Sorry.
Comment 3 Tim-Philipp Müller 2013-12-02 23:47:16 UTC 
Did this solve something for you?
Comment 4 Matej Knopp 2013-12-02 23:52:24 UTC 
Well, yes, but it's very specific use case. I want users to be able to override x264 arguments that I set through properties. However if this really works as intended (as it seems), I can just keep the patch or configure everything through option-string.
Comment 5 Sebastian Dröge (slomo) 2014-01-01 13:37:38 UTC 
So let's close this then? Or is there anything left to be done that can be improved?
Comment 6 Tim-Philipp Müller 2016-02-21 22:12:14 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!