After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719657 - gstmpegvideoparser: debug category not always initialized soon enough
gstmpegvideoparser: debug category not always initialized soon enough
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.2.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-01 18:55 UTC by Matej Knopp
Modified: 2013-12-13 00:14 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matej Knopp 2013-12-01 18:55:46 UTC
I've got a dvr-ms file which has something weird in codec-data. The parser tries to parse that (gst_mpegv_parse_process_config) which calls gst_mpeg_video_packet_parse_sequence_header that logs error. This is called before the debug category is initialized (which happens in gst_mpeg_video_parse).
Comment 1 Matej Knopp 2013-12-01 18:56:21 UTC
Perhaps there should be a separate call to initialize the debug category called when plugin gets loaded?
Comment 2 Sebastian Dröge (slomo) 2013-12-02 08:18:32 UTC
You could just put the initialization into class_init or the get_type function, then it will be called early enough
Comment 3 Olivier Crête 2013-12-04 23:02:33 UTC
GstMpegParser isn't an object, so there is no class_init or get_type, but I changed it to just initialize the category in both places.

Fixed in git master

commit a167173063ce7407d9a46196d90b512bfff1f5fe
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Wed Dec 4 17:31:27 2013 -0500

    mpegvideoparser: Also initialize debug category in parse_sequence_header
    
    Also remove the useless initialized flag, this is already done by the macro
    
    https://bugzilla.gnome.org/show_bug.cgi?id=719657
Comment 4 Tim-Philipp Müller 2013-12-13 00:14:35 UTC
Picked into 1.2