After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719564 - Fixes for the updated Bluetooth panel
Fixes for the updated Bluetooth panel
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks: 719565
 
 
Reported: 2013-11-29 15:54 UTC by Bastien Nocera
Modified: 2014-07-01 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wizard: Remove plugins usage (2.67 KB, patch)
2013-11-29 15:56 UTC, Bastien Nocera
committed Details | Review
lib: Remove plugins support (24.05 KB, patch)
2013-11-29 15:56 UTC, Bastien Nocera
committed Details | Review
lib: Insert data straight away (2.88 KB, patch)
2013-11-29 15:57 UTC, Bastien Nocera
committed Details | Review
lib: Print "default-adapter-discovering" when it changes (1.53 KB, patch)
2013-11-29 15:57 UTC, Bastien Nocera
committed Details | Review
lib: Fix "default-adapter-discoverable" property (2.34 KB, patch)
2013-11-29 15:57 UTC, Bastien Nocera
committed Details | Review
lib: Remove killswitch functionality (31.31 KB, patch)
2013-11-29 15:57 UTC, Bastien Nocera
committed Details | Review
lib: Fix "default-adapter-name" property (1.91 KB, patch)
2013-11-29 15:57 UTC, Bastien Nocera
committed Details | Review
lib: Make _set_discoverable() more efficient (1.71 KB, patch)
2013-12-02 18:17 UTC, Bastien Nocera
committed Details | Review
lib: Remove deleted functions from symbols file (780 bytes, patch)
2013-12-02 18:17 UTC, Bastien Nocera
committed Details | Review
lib: Add Settings widget (61.03 KB, patch)
2013-12-02 18:17 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-11-29 15:54:08 UTC
.
Comment 1 Bastien Nocera 2013-11-29 15:56:50 UTC
Created attachment 263134 [details] [review]
wizard: Remove plugins usage

It was used by a test plugin we ship ourselves for Geoclue 1.x,
and NetworkManager. Given that NetworkManager doesn't make use
of it anymore, let's remove it.
Comment 2 Bastien Nocera 2013-11-29 15:56:55 UTC
Created attachment 263136 [details] [review]
lib: Remove plugins support

Unused by either the wizard or the settings panel.
Comment 3 Bastien Nocera 2013-11-29 15:57:01 UTC
Created attachment 263137 [details] [review]
lib: Insert data straight away

The data is available, so insert the new devices with their values
straight away. This means that front-ends don't receive as many
signals, and that they don't have to filter out NULL names.
Comment 4 Bastien Nocera 2013-11-29 15:57:05 UTC
Created attachment 263138 [details] [review]
lib: Print "default-adapter-discovering" when it changes
Comment 5 Bastien Nocera 2013-11-29 15:57:11 UTC
Created attachment 263139 [details] [review]
lib: Fix "default-adapter-discoverable" property

Which wasn't getting updated when the default-adapter changed.
Comment 6 Bastien Nocera 2013-11-29 15:57:16 UTC
Created attachment 263140 [details] [review]
lib: Remove killswitch functionality

That code has now moved to gnome-settings-daemon's Rfkill interface.
Comment 7 Bastien Nocera 2013-11-29 15:57:26 UTC
Created attachment 263141 [details] [review]
lib: Fix "default-adapter-name" property

Which wasn't getting updated when the default-adapter changed.
Comment 8 Bastien Nocera 2013-12-02 18:17:23 UTC
Created attachment 263323 [details] [review]
lib: Make _set_discoverable() more efficient

Get the properties proxy directly from the adapter treepath.
This avoids an unnecessary search in the treeview.
Comment 9 Bastien Nocera 2013-12-02 18:17:28 UTC
Created attachment 263324 [details] [review]
lib: Remove deleted functions from symbols file
Comment 10 Bastien Nocera 2013-12-02 18:17:34 UTC
Created attachment 263325 [details] [review]
lib: Add Settings widget

Rather than implementing the majority of the settings widget
inside the control-center, implement it within gnome-bluetooth
so we can cut down on the necessary amount of exported symbols
and functions.

TODO:
- Spacing is all broken in the properties panel
- Pairing isn't implemented
Comment 11 Bastien Nocera 2013-12-06 11:03:20 UTC
And MORE!

Attachment 263134 [details] pushed as 56a4ad7 - wizard: Remove plugins usage
Attachment 263136 [details] pushed as 074dbf2 - lib: Remove plugins support
Attachment 263137 [details] pushed as 3ad555e - lib: Insert data straight away
Attachment 263138 [details] pushed as 6493bd2 - lib: Print "default-adapter-discovering" when it changes
Attachment 263139 [details] pushed as 6f71048 - lib: Fix "default-adapter-discoverable" property
Attachment 263140 [details] pushed as f9a2d4e - lib: Remove killswitch functionality
Attachment 263141 [details] pushed as cf80e20 - lib: Fix "default-adapter-name" property
Attachment 263323 [details] pushed as 10f0cf5 - lib: Make _set_discoverable() more efficient
Attachment 263324 [details] pushed as 40444c9 - lib: Remove deleted functions from symbols file
Attachment 263325 [details] pushed as 4b2c4fd - lib: Add Settings widget
Comment 12 Milan Crha 2014-06-27 13:43:20 UTC
Just a note, syncevolution used the plugin API, to give more comfort to users.
Comment 13 Bastien Nocera 2014-07-01 13:50:32 UTC
(In reply to comment #12)
> Just a note, syncevolution used the plugin API, to give more comfort to users.

The configuration should probably be done in an application instead now.