After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719549 - pango-utils: Fix a potential strtol(NULL) call
pango-utils: Fix a potential strtol(NULL) call
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-29 12:40 UTC by Philip Withnall
Modified: 2013-12-02 11:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pango-utils: Fix a potential strtol(NULL) call (1.03 KB, patch)
2013-11-29 12:40 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2013-11-29 12:40:32 UTC 
Found by scan-build.
Comment 1 Philip Withnall 2013-11-29 12:40:34 UTC 
Created attachment 263115 [details] [review]
pango-utils: Fix a potential strtol(NULL) call

parse_int() is called by pango_parse_enum(), which permits the enum
string to be NULL. This string is passed directly through to parse_int()
and then to strtol(), which is tagged as nonnull.

Found by scan-build.
Comment 2 Behdad Esfahbod 2013-11-29 19:26:42 UTC 
Haven't studied the patch, but I assume you know what you are doing :).  Please commit.
Comment 3 Philip Withnall 2013-12-02 11:34:15 UTC 
Attachment 263115 [details] pushed as 05f7dcd - pango-utils: Fix a potential strtol(NULL) call