After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719279 - Use gnome-shell's AppMenu
Use gnome-shell's AppMenu
Status: RESOLVED OBSOLETE
Product: shotwell
Classification: Other
Component: ux
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on: 768271
Blocks: 719204
 
 
Reported: 2013-04-30 11:15 UTC by Shotwell Maintainers
Modified: 2018-07-03 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use AppMenu (22.02 KB, patch)
2016-11-26 09:17 UTC, Jens Georg
none Details | Review
Use AppMenu (24.58 KB, patch)
2016-11-30 22:23 UTC, Jens Georg
committed Details | Review

Description Charles Lindsay 2013-11-25 22:11:04 UTC


---- Reported by shotwell-maint@gnome.bugs 2013-04-30 04:15:00 -0700 ----

Original Redmine bug id: 6883
Original URL: http://redmine.yorba.org/issues/6883
Searchable id: yorba-bug-6883
Original author: Xavier Claessens
Original description:

To get nicely integrated with gnome-shell's design, shotwel could use the app-
menu instead of the menubar. This could need to discuss which item to have in
the app menu, and eventually move the rest to a gear menu and/or toolbar like
nautilus.

Related issues:
related to shotwell - Feature #7241: Consider using Gtk.HeaderBar (Open)



---- Additional Comments From shotwell-maint@gnome.bugs 2013-07-16 02:24:00 -0700 ----

### History

####

#1

Updated by Tomáš Hnyk 7 months ago

If implemented, it would be nice if it worked only under Gnome Shell as some
users (me included) do not use Gnome Shell and hate that particular design
decision.

####

#2

Updated by Jim Nelson 7 months ago

  * **Category** set to _ux_
  * **Target version** set to _0.15.0_

We talked internally about this question. Supporting multiple menu systems
means a lot of conditional code as menu items are shuffled between the AppMenu
and the normal menu scheme.

Additionally, I don't think Shotwell will ever move to a pure gear menu
interface. There's a lot of menu items and it doesn't strike me as a step
forward to stuff all of them into a single cascading dropdown menu.

Both of the above are, of course, worth discussing, so don't take this as the
final word on the matter.

####

#3

Updated by Jim Nelson 6 months ago

  * **Target version** deleted (<strike>_0.15.0_</strike>)

####

#4

Updated by Xavier Claessens 4 months ago

Here is a branch:
http://cgit.collabora.com/git/user/xclaesse/shotwell.git/log/?h=app-menu

I'm not sure it is the best way to do it, though. Comments?

####

#5

Updated by Joe Bylund 4 months ago

Xavier, should this only affect Shotwell while running in gnome shell?

####

#6

Updated by Yosef Or Boczko 4 months ago

See "gtk-shell-shows-app-menu" setting:

https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-
shell-shows-app-menu

if the "gtk-shell-shows-app-menu" setting is FALSE, the AppMenu will be
displayed as menu on menubar (will be created automatically).

Need to do something like this:

ׂgboolean appmenu;

g_object_get (gtk_settings_get_default (), "gtk-shell-shows-app-menu",
&appmenu, NULL);

if (appmenu) {

/* Create app menu */

}

else {

/* Add the item of an appmenu to the gearmenu */

}

####

#7

Updated by Xavier Claessens 4 months ago

Ok, branch updated to do that. Thanks for the tip.



--- Bug imported by chaz@yorba.org 2013-11-25 22:11 UTC  ---

This bug was previously known as _bug_ 6883 at http://redmine.yorba.org/show_bug.cgi?id=6883

Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Jens Georg 2016-11-26 09:17:38 UTC
Created attachment 340785 [details] [review]
Use AppMenu

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 2 Jens Georg 2016-11-30 22:23:32 UTC
Created attachment 341093 [details] [review]
Use AppMenu

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 3 Jens Georg 2016-12-01 00:35:33 UTC
Attachment 341093 [details] pushed as 6e6a51b - Use AppMenu
Comment 4 Jens Georg 2016-12-23 11:30:48 UTC
That needs a better plan for non-gnome-shell and non-unity environments.
Comment 5 Jens Georg 2018-07-03 14:04:17 UTC
GNOME will probably phase out the AppMenu anyway