After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715168 - URL in RTP-Info miss the query part
URL in RTP-Info miss the query part
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-25 15:09 UTC by Branko Subasic
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Include query part of request URL in RTP-Info header in PLAY response (1.97 KB, patch)
2013-11-25 19:05 UTC, Branko Subasic
none Details | Review
Save url's from SETUP request and use them when generating PLAY response (12.35 KB, patch)
2013-11-27 15:09 UTC, Branko Subasic
committed Details | Review

Description Branko Subasic 2013-11-25 15:09:27 UTC
When responding to a PLAY request the query part of the URL is not included in the RTP-Info headers. From the RTSP v2.0 draft:

 url:  Indicates the stream URI for which the following RTP parameters
         correspond, this URI MUST be the same as used in the SETUP
         request for this media stream.  Any relative URI MUST use the
         Request-URI as base URI.  This parameter MUST be present.

I will attach a small patch fixing the issue.
Comment 1 Branko Subasic 2013-11-25 19:05:29 UTC
Created attachment 261476 [details] [review]
Include query part of request URL in RTP-Info header in PLAY response
Comment 2 Wim Taymans 2013-11-26 09:14:50 UTC
If you want to implement if like that, you would need to store the URL used in the SETUP (in the session or so) and then use that to reply. You can't assume the query paramaters in the PLAY are the same as the ones used in SETUP.
Comment 3 Branko Subasic 2013-11-27 15:09:03 UTC
Created attachment 262949 [details] [review]
Save url's from SETUP request and use them when generating PLAY response
Comment 4 Wim Taymans 2013-11-28 17:03:10 UTC
Changed it slightly to store the setup url in the StreamTransport, where the other config information is of the stream in the session.

commit b16b47f68daccf0a939673f5246ed1d1ae88964b
Author: Branko Subasic <branko@axis.com>
Date:   Wed Nov 27 15:04:04 2013 +0100

    check: add test for uri in setup
    
    Added unit tests for the new functionality in GstRTSPStreamTransport.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=715168

commit 421499c10274201d83c143627b6b487049e1192c
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Thu Nov 28 17:47:18 2013 +0100

    client: store setup uri and use in PLAY response
    
    Store the uri used when doing the setup and use that in the PLAY
    response.
    
    fixes https://bugzilla.gnome.org/show_bug.cgi?id=715168

commit 568477d9b53c5dfb46b2cf1517a1885c3feb519a
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Thu Nov 28 17:35:45 2013 +0100

    stream-transport: add method to get/set url