After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715088 - build: support tracker 0.18
build: support tracker 0.18
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-23 23:40 UTC by Dominique Leuenberger
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: support tracker 0.18 (1.04 KB, patch)
2013-11-23 23:40 UTC, Dominique Leuenberger
committed Details | Review

Description Dominique Leuenberger 2013-11-23 23:40:07 UTC
Tracker, as usually, renamed the .pc file for 0.18.
Let's support it.
Comment 1 Dominique Leuenberger 2013-11-23 23:40:09 UTC
Created attachment 261328 [details] [review]
build: support tracker 0.18
Comment 2 Zeeshan Ali 2013-11-24 18:52:56 UTC
<zeenix> is the tracker api changing w/ every minor release?
<zeenix> if not, i don't see why the pc file need to change version
<zeenix> juergbi: ^
<phako> talked with martyn about this, but I forgot the reason tbh
<juergbi> it's probably high time that we guarantee API for longer, yes
<juergbi> i'm not much involved anymore, though, so it's not my call

Martyn?
Comment 3 Martyn Russell 2013-11-25 11:56:50 UTC
(In reply to comment #2)
> <zeenix> is the tracker api changing w/ every minor release?
> <zeenix> if not, i don't see why the pc file need to change version
> <zeenix> juergbi: ^
> <phako> talked with martyn about this, but I forgot the reason tbh
> <juergbi> it's probably high time that we guarantee API for longer, yes
> <juergbi> i'm not much involved anymore, though, so it's not my call
> 
> Martyn?

I've been wondering if we should do a 1.0 release or something like that. Not much is changing lately in the code base other than fixing deprecation in GLib and adding support for the odd file format. We're also improving the portability at times, but not much major work is going on, things are reasonably stable lately.

I need to take a look before really answering this question properly for 0.16 --> 0.18 to be fair. APIs do change between minor versions like 0.14 --> 0.16 traditionally or if new functionality is quite disruptive and may cause unknown regressions. It's not just about the API/ABI but also features and required upgrades (e.g. GConf --> GSettings).

I am happy to make 0.17 a 1.0 release. Technically, I've always followed the GLib/GTK+ release approach closely.

I would like to know what the team think, mostly this is from: Juergbi, pvanhoof, garnacho and ssam2. Thoughts?

Not sure I answered your question zeenix :)
Comment 4 Zeeshan Ali 2013-11-25 13:03:19 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > <zeenix> is the tracker api changing w/ every minor release?
> > <zeenix> if not, i don't see why the pc file need to change version
> > <zeenix> juergbi: ^
> > <phako> talked with martyn about this, but I forgot the reason tbh
> > <juergbi> it's probably high time that we guarantee API for longer, yes
> > <juergbi> i'm not much involved anymore, though, so it's not my call
> > 
> > Martyn?
> 
> I've been wondering if we should do a 1.0 release or something like that. Not
> much is changing lately in the code base other than fixing deprecation in GLib
> and adding support for the odd file format. We're also improving the
> portability at times, but not much major work is going on, things are
> reasonably stable lately.
> 
> I need to take a look before really answering this question properly for 0.16
> --> 0.18 to be fair.

Sure, we have a patch for now anyway. :)

> I am happy to make 0.17 a 1.0 release. Technically, I've always followed the
> GLib/GTK+ release approach closely.

Huh? They are not changing their .pc file version on every minor release, e.g gtk+-3.0.
Comment 5 Martyn Russell 2013-11-26 16:31:08 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > I am happy to make 0.17 a 1.0 release. Technically, I've always followed the
> > GLib/GTK+ release approach closely.
> 
> Huh? They are not changing their .pc file version on every minor release, e.g
> gtk+-3.0.

I never said exactly.

About the .pc file, I don't feel strongly about how this is done or if we change that and it's a minor detail.

I agree it's a pain in the arse for some people but since we've never had a major release (e.g. 1.0, 2.0, etc) we couldn't exactly make the API changes we've made in the past without bumping the .pc version here. Also using (for example) a tracker-sparql-0.10 pc file for version 0.16 would just be strange and confusing for people.

We're currently talking about doing a 1.0 release for improved stability in another bug and given the project isn't in heavy development of new features, we could move to a tracker-{sparql|extract|...}-1.0.pc and make things easier for people.

Patches welcomed :)
Comment 6 Zeeshan Ali 2013-12-11 18:25:02 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > I am happy to make 0.17 a 1.0 release. Technically, I've always followed the
> > > GLib/GTK+ release approach closely.
> > 
> > Huh? They are not changing their .pc file version on every minor release, e.g
> > gtk+-3.0.
> 
> I never said exactly.
> 
> About the .pc file, I don't feel strongly about how this is done or if we
> change that and it's a minor detail.
> 
> I agree it's a pain in the arse for some people

Some people? Its pain in the arse for every (tracer-sparql using) app developer out there.

> but since we've never had a
> major release (e.g. 1.0, 2.0, etc) we couldn't exactly make the API changes
> we've made in the past without bumping the .pc version here.

Sure, where there *is* incompatible changes, it makes perfect sense to change .so and .pc versions but it hasn't been the case for a while now.

> Also using (for
> example) a tracker-sparql-0.10 pc file for version 0.16 would just be strange
> and confusing for people.
> 
> We're currently talking about doing a 1.0 release for improved stability in
> another bug and given the project isn't in heavy development of new features,
> we could move to a tracker-{sparql|extract|...}-1.0.pc and make things easier
> for people.

Indeed you can.