Created attachment 261320 [details] [review]
connection dialog and about dialog : don't open if already open

When connection dialog or about dialog are open, we still can go to app menu
and open them again. We do'nt want this.

Review of attachment 261320 [details] [review]:

lgtm, thanks!

Review of attachment 261320 [details] [review]:

just a nitpick before committing. Add in the commit message the file modified like:
application: don't open dialogs if already opened

Also, commit messages has to be 80 chars width.

Review of attachment 261320 [details] [review]:

::: src/application.js
@@ +388,2 @@
     _onListConnections: function() {
+        if (this._connectionsDialogOpened)

If you used the dialog itself for the test, you could present() it if it already exists:

if (this._connectionsDialog) {
    this._connectionsDialog.dialog.present();
    return;
}

Currently it doesn't matter much, as the only non-obscure way to get to the dialog is via the app menu, which means Polari is already focused. But if we add support for .desktop actions at one point, it may be possible to trigger the action from elsewhere.

Created attachment 261369 [details] [review]
application: don't open dialogs if already opened

When connection dialog or about dialog are open, we still can go to app
menu and open them again. We don't want this.

Review of attachment 261369 [details] [review]:

LGTM

Attachment 261369 [details] pushed as 10d310f - application: don't open dialogs if already opened