After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715040 - Avoid starting tracker-store twice
Avoid starting tracker-store twice
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-general
Depends on:
Blocks:
 
 
Reported: 2013-11-22 21:02 UTC by Colin Walters
Modified: 2013-11-29 04:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid starting tracker-store twice (1.41 KB, patch)
2013-11-22 21:02 UTC, Colin Walters 		committed Details | Review
tracker-store.desktop: Add missing flags argument (1.00 KB, patch)
2013-11-28 15:44 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2013-11-22 21:02:14 UTC 
We install both of:

/etc/xdg/autostart/tracker-store.desktop
/usr/share/dbus-1/services/org.freedesktop.Tracker1

If something else speaks to tracker via during login, what will happen
is that dbus-daemon will spawn one, and gnome-session will also spawn
one, and one of these will emit a critical message.

To fix this, change the .desktop file merely use DBus (it'd be nice if
there was an easier way to do this).

Instead, maybe we could consider only dbus-activating tracker?  In
other words, if nothing wants to talk to us, maybe we shouldn't be
starting by default...
Comment 1 Colin Walters 2013-11-22 21:02:15 UTC 
Created attachment 261271 [details] [review]
Avoid starting tracker-store twice
Comment 2 Martyn Russell 2013-11-25 12:03:02 UTC 
Comment on attachment 261271 [details] [review]
Avoid starting tracker-store twice

Shouldn't that be @bindir@/gdbus ...

Actually, this patch makes a lot of sense AFAICT. I didn't realise it was being started twice. Usually the miner-fs instantiates the store via DBus here.

I can't think of any cases this might break off the top of my head.
Comment 3 Colin Walters 2013-11-25 13:08:34 UTC 
There's no point to using @bindir@ here as we may not technically be
in the same prefix as GLib.  There's really no way to win with that;
basically you have to configure all of GNOME stuff to be in the same
prefix.

Attachment 261271 [details] pushed as 3ad3b79 - Avoid starting tracker-store twice
Comment 4 Colin Walters 2013-11-28 15:40:54 UTC 
Sorry, I forgot to amend this patch before pushing, it's broken.
Comment 5 Colin Walters 2013-11-28 15:44:46 UTC 
Created attachment 263035 [details] [review]
tracker-store.desktop: Add missing flags argument

Sorry, forgot to rebase this.
Comment 6 Colin Walters 2013-11-29 04:40:53 UTC 
Attachment 263035 [details] pushed as 6eee8b9 - tracker-store.desktop: Add missing flags argument