After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715032 - Fix CRITICALs when loading a document from Google or SkyDrive
Fix CRITICALs when loading a document from Google or SkyDrive
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.10.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-22 18:31 UTC by Debarshi Ray
Modified: 2013-11-25 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pdf-loader: Fix CRITICALs when loading from Google or SkyDrive (1.25 KB, patch)
2013-11-22 18:36 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-11-22 18:31:40 UTC 
This is a fallout from:

commit 53a17bdb40d5f82f8ac8f655afc657bcf835da22
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Mon Aug 19 12:01:40 2013 +0200

    lib: support loading non-native GVfs URIs
    
    Even though libview has EvJobLoadGFile, it doesn't really work. eg.,
    PDFs fail to load over WebDAV. So, we download the files and convert
    them to PDF using unoconv, if needed, before showing them.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=686527

Patch coming up.
Comment 1 Debarshi Ray 2013-11-22 18:36:48 UTC 
Created attachment 261256 [details] [review]
pdf-loader: Fix CRITICALs when loading from Google or SkyDrive
Comment 2 Cosimo Cecchi 2013-11-22 18:42:34 UTC 
Review of attachment 261256 [details] [review]:

Looks good to me, thanks.
Comment 3 Debarshi Ray 2013-11-25 12:43:14 UTC 
Comment on attachment 261256 [details] [review]
pdf-loader: Fix CRITICALs when loading from Google or SkyDrive

Thanks for the review.