After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 714712 - style messages that are code diffs so they're easier to read
style messages that are code diffs so they're easier to read
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: client
unspecified
Other All
: Low enhancement
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: 714883
Blocks:
 
 
Reported: 2013-04-14 07:45 UTC by Geary Maintainers
Modified: 2018-10-28 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Charles Lindsay 2013-11-21 23:11:25 UTC


---- Reported by geary-maint@gnome.bugs 2013-04-14 00:45:00 -0700 ----

Original Redmine bug id: 6815
Original URL: http://redmine.yorba.org/issues/6815
Searchable id: yorba-bug-6815
Original author: Alex Lourie
Original description:

Allow change formatting if git (or other SCM) patch is detected so that the
patch is shown as colorized diff.



---- Additional Comments From geary-maint@gnome.bugs 2013-11-14 17:16:00 -0800 ----

### History

####

#1

Updated by Charles Lindsay 7 months ago

  * **Status** changed from _Open_ to _Need Information_

Alex, I'm not sure what you're asking here. What formatting would change? What
exactly would we detect? How/where would we display a patch?

####

#2

Updated by Alex Lourie 7 months ago

Hi Charles

Well, basically, now I see no formatting when I read the message; it's just
plain. I would like to be able somehow to detect (either manually or
automatically) that the mail I'm reading is actually a patch sent from git,
and if so, show it to me colorised, just as it would be in gitdiff (or any
diff tool).

####

#3

Updated by Charles Lindsay 7 months ago

  * **Subject** changed from _Allow change formatting if git (or other SCM) patch is detected_ to _style messages that are code diffs so they're easier to read_
  * **Category** set to _client_
  * **Status** changed from _Need Information_ to _Open_
  * **Target version** set to _0.5.0_

Ah, so you just want special highlighting/styling applied to messages that are
diffs. That's an interesting feature idea.

####

#4

Updated by Alex Lourie 7 months ago

Charles Lindsay wrote:

> Ah, so you just want special highlighting/styling applied to messages that
are diffs. That's an interesting feature idea.

Yes!

Thank you!

####

#5

Updated by Jim Nelson 7 months ago

  * **Priority** changed from _Normal_ to _Low_

There's two aspects to this ticket: (a) colorizing a patch included inline in
the email (i.e. copy-and-pasted in) and (b) displaying a diff attachment as
though it was inline (much like attached emails) a la #6450.

While a nice idea, this is really a developers-only feature, and so I'm going
to knock this down to Low. Patches welcome (so to speak).

####

#6

Updated by Alex Lourie 7 months ago

Hi Jim

Jim Nelson wrote:

> There's two aspects to this ticket: (a) colorizing a patch included inline
in the email (i.e. copy-and-pasted in)

That's what I'm interested in. We use 'git send-email' in our workflow and it
includes the patch inline.

> While a nice idea, this is really a developers-only feature, and so I'm
going to knock this down to Low. Patches welcome (so to speak).

Thanks!

####

#7

Updated by Jim Nelson 7 days ago

  * **Target version** deleted (<strike>_0.5.0_</strike>)



--- Bug imported by chaz@yorba.org 2013-11-21 23:11 UTC  ---

This bug was previously known as _bug_ 6815 at http://redmine.yorba.org/show_bug.cgi?id=6815

Unknown version " in product geary. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Michael Gratton 2018-01-03 23:29:45 UTC
This would be done as a plugin (maybe using GtkSourceView?), so marking as depending on Bug 714883.
Comment 2 Michael Gratton 2018-10-28 22:26:22 UTC
I just wrote up a tracking bug for the plugin system over at gitlab that collects all of the requirements for feature requests that should be implemented as plugins in the one place, so closing this bug in favour of that ticket: https://gitlab.gnome.org/GNOME/geary/issues/155