After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 714653 - Remove unnecessary code from GearyController.do_show_message()
Remove unnecessary code from GearyController.do_show_message()
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: client
0.3.0
Other All
: Normal normal
: ---
Assigned To: Robert Schroll
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-06 11:47 UTC by Robert Schroll
Modified: 2013-05-01 06:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Remove-unneeded-code-from-GearyController.do_show_me.patch (1.32 KB, patch)
2013-02-06 23:47 UTC, Robert Schroll
none Details | Review

Description Charles Lindsay 2013-11-21 20:28:29 UTC


---- Reported by rschroll@gmail.com 2013-02-06 15:47:00 -0800 ----

Original Redmine bug id: 6340
Original URL: http://redmine.yorba.org/issues/6340
Searchable id: yorba-bug-6340
Original author: Robert Schroll
Original description:

I was looking at this method and noticed that the list 'unread_ids' wasn't
doing anything anymore. Before, it had been used to keep track of which
messages to mark as read, but this has been moved to the ConversationViewer
now. So we can get rid of this now.



---- Additional Comments From geary-maint@gnome.bugs 2013-05-01 11:48:00 -0700 ----

### History

####

#1

Updated by Robert Schroll 10 months ago

  * **Status** changed from _Review_ to _5_

Applied in changeset 48eeb472c424f811f33b0ded83dd4be1a665e09e.

####

#2

Updated by Jim Nelson 10 months ago

  * **Category** set to _client_
  * **Assignee** set to _Robert Schroll_
  * **Target version** set to _0.3.0_
  * **Resolution** set to _fixed_

Good catch!

####

#3

Updated by Charles Lindsay 7 months ago

  * **Status** changed from _5_ to _Fixed_



--- Bug imported by chaz@yorba.org 2013-11-21 20:28 UTC  ---

This bug was previously known as _bug_ 6340 at http://redmine.yorba.org/show_bug.cgi?id=6340
Imported an attachment (id=261089)

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.