GNOME Bugzilla – Bug 714212
Trash / Delete message
Last modified: 2016-03-21 13:10:28 UTC
---- Reported by jim@yorba.org 2011-06-22 10:40:00 -0700 ---- Original Redmine bug id: 3772 Original URL: http://redmine.yorba.org/issues/3772 Searchable id: yorba-bug-3772 Original author: Jim Nelson Original description: Message should go to some kind of Trash, and when emptied is deleted from local storage and the server. A Delete function should be available when Trash is not. Related issues: related to geary - 7626: Warn user when deleting email (Open) related to geary - 5782: Grayed delete button displayed in All Mail and Sent (Open) related to geary - 6613: Generic IMAP server Delete should move to Trash (Open) related to geary - Feature #6639: Empty Trash feature (Open) duplicated by geary - Feature #6813: Add shortcut to move to Trash (Duplicate) duplicated by geary - 7083: No GUI way for deleting conversations? (Duplicate) duplicated by geary - Feature #5953: Delete messages, skipping Archive (Duplicate) ---- Additional Comments From geary-maint@gnome.bugs 2013-08-12 18:08:00 -0700 ---- ### History #### #1 Updated by Adam Dingle over 2 years ago * **Target version** set to _0.1_ #### #2 Updated by Adam Dingle over 1 year ago * **Target version** deleted (<strike>_0.1_</strike>) #### #3 Updated by Jim Nelson about 1 year ago * **Category** set to _client_ * **Target version** set to _0.3.0_ #### #4 Updated by Jim Nelson 12 months ago This has been requested downstream: https://bugs.launchpad.net/geary/+bug/1082561 #### #5 Updated by Jim Nelson 10 months ago Note that completing this ticket (and displaying both buttons in the UI, grayed out appropriately) would satisfy ticket #5782. #### #6 Updated by Jim Nelson 10 months ago * **Category** changed from _client_ to _client+engine_ #### #7 Updated by Jim Nelson 10 months ago * **Target version** changed from _0.3.0_ to _0.4.0_ #### #8 Updated by Jim Nelson 8 months ago This should also work for non-Gmail servers. #### #9 Updated by Felipe Contreras 7 months ago Jim Nelson wrote: > Message should go to some kind of Trash, and when emptied is deleted from local storage and the server. I don't get it. There is a Trash folder in More that works perfectly fine, the only thing missing is a keyboard shortcut. #### #10 Updated by Charles Lindsay 7 months ago The Trash folder might work fine for you, Felipe, but this ticket about supporting the trash operation across all services and IMAP implementations. #### #11 Updated by Charles Lindsay 7 months ago As Felipe points out in #6813, for many users this could be as simple as making a keyboard shortcut (or toolbar button) that moves mail to the existing Trash folder, without going through archive. #### #12 Updated by Jim Nelson 7 months ago * **Subject** changed from _Delete message_ to _Trash / Delete message_ * **Description** updated (diff) To elucidate our goal for this ticket: Geary uses an adaptive system when dealing with servers of differing capabilities. Our plan is for a Delete button to move the message to a Trash folder if available. (It should be marked Trash in this case.) If not, then Delete should do exactly that: hard-delete the message. Now, in the first case where there is a Trash available, users may still want to hard-delete a message. In that case, we would still offer Delete, but it may not take the form of another toolbar button. (Perhaps only available via a keyboard accelerator or holding down Shift while pressing the button, etc.) This is the kind of thing we need to discuss when we start working on the feature. **In every case, no matter the server, a hard-delete will be available.** However, if a Trash is available, Geary will prefer that one (via default behavior) because it can be undone, whereas the first cannot. I've updated the description to capture some of the above. #### #13 Updated by John T. 5 months ago This issue makes Geary unusable for anyone who uses Gmail and (shock horror) doesn't conflate the completely different concepts of archive and delete. #### #14 Updated by Jim Nelson 5 months ago You can drag conversations from the middle list to the Trash folder on the left column. Obviously that's not the most convenient way to work, but it is available until we have this feature implemented. #### #15 Updated by Jim Nelson 3 months ago * **Target version** changed from _0.4.0_ to _0.5.0_ --- Bug imported by chaz@yorba.org 2013-11-21 20:25 UTC --- This bug was previously known as _bug_ 3772 at http://redmine.yorba.org/show_bug.cgi?id=3772 Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
This is ready for review at wip/trash-714212. I believe everything discussed has been sorted out. This would also close bug #714293 and bug #714826, with the assumption that we'll eventually get better special folder detection in "other" accounts.
*** Bug 721331 has been marked as a duplicate of this bug. ***
As discussed, this patch is quite close. A couple of changes: * Geary.FolderProperties has an is_local_only property that should work for your needs. * I'd like to avoid things like Geary.Account.can_support_archive. My instinct is to create an AccountProperties class (like FolderProperties), but don't think that's justified quite yet for a single property. I also don't think we should put it in AccountInformation, which has a different purpose. So, what I ask is to make it an abstract property (i.e "can-support-archive") in the interface and implement it in AbstractAccount. AbstractAccount could take the value in its constructor, forcing child classes to provide it.
Fixed in commit:968743a.