---- Reported by geary-maint@gnome.bugs 2013-08-26 22:49:00 -0700 ----

Original Redmine bug id: 7394
Original URL: http://redmine.yorba.org/issues/7394
Searchable id: yorba-bug-7394
Original author: Yosef Or Boczko
Original description:

The setting "gtk-toolbar-icon-size" is ignored in

GTK+ 3.9.x, therefore the value default is the single

value, and because the value default is

GTK_ICON_SIZE_LARGE_TOOLBAR, the toolbar in GTK+ 3.9.x

is very large.

Also in nautilus finished use in this function:

https://git.gnome.org/browse/nautilus/commit/?id=10a7f7b511cddb0648b94a223ddcc
367b9cba7a1

I attached two images and one patch.



---- Additional Comments From geary-maint@gnome.bugs 2013-09-03 16:28:00 -0700 ----

### History

####

#1

Updated by Charles Lindsay 3 months ago

  * **Status** changed from _Open_ to _Review_

####

#2

Updated by Jim Nelson 3 months ago

  * **Category** set to _ux_
  * **Priority** changed from _Normal_ to _High_
  * **Target version** set to _0.5.0_

Alas, like your other patch, we can't take this quite yet. If there was a way
to workaround this without #ifdefs or depending on GTK version numbers, I'd
gladly consider it.

####

#3

Updated by Yosef Or Boczko 3 months ago

  * **File** 0001-Fix-the-size-of-the-buttons-in-the-toolbar-in-new-GT.patch added

Well, this possible - see the patch.

But the patch become the function to little superfluous.

####

#4

Updated by Yosef Or Boczko 3 months ago

I forgot to note:

The patch is cause ignore from the setting "gtk-toolbar-icon-size",

also in the old version of GTK+...

So I think is better simply to remove the function.

####

#5

Updated by Yosef Or Boczko 3 months ago

I think need to take the original patch.

The target of the function get_icon_size() is to

set margin according to the "gtk-toolbar-icon-size"

setting, but also the second patch ignore from this setting.

So, we need simply not set custom margin to the image,

to remove the get_icon_size() function.

####

#6

Updated by Jim Nelson 3 months ago

Yosef, are you saying we should use 0001- or 0003-?

####

#7

Updated by Yosef Or Boczko 3 months ago

Jim, 0003.



--- Bug imported by chaz@yorba.org 2013-11-21 20:21 UTC  ---

This bug was previously known as _bug_ 7394 at http://redmine.yorba.org/show_bug.cgi?id=7394
Imported an attachment (id=260717)
Imported an attachment (id=260718)
Imported an attachment (id=260719)
Imported an attachment (id=260720)

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution