GNOME Bugzilla – Bug 712796
videodecoder: incorrect timestamps sequence
Last modified: 2013-11-26 11:34:19 UTC
Some dvds have probably bugs which cause incorrect timestamps sequence. For example 887266666 then 847266666. It is not a problem if you play it. But it will cause problems if you convert it to vp8/mkv. This is probably reason for Bug 712219 sample file is here: https://www.dropbox.com/s/4zlkvnt2igf9a2z/bug_timestamp.mpeg you can catch brocken timestamps with this command: gst-launch-1.0 -vm filesrc location=bug_timestamp.mpeg ! mpegpsdemux ! mpegvideoparse ! identity check-imperfect-timestamp=1 ! fakesink silent=1 | grep ident
Same issue on other dvd. Probably some timestamp is extracted incorrectly.
Created attachment 261116 [details] [review] videodecoder: avoid descending output timestamps This should fix this and avoid some weird timestamps, though it may/will still not lead to a perfect stream. The latter makes sense this is not necessarily a perfect fix/solution in various ways, but there is quite some timestamp guestimating heuristic happening in videodecoder trying to suit all possible cases, and this seems about as much tweaking as is possible/advisable (also in view of no problems at playback). Other suggestions of course still welcome.
Hi, thank you for the patch. it make timestamp look less wired :) Suddenly it wont fix Bug 712219, so it is probably unrelated to this issue.
commit ee86a91957b73e57c1d9b540c53b21e0fc49def4 Author: Mark Nauwelaerts <mnauw@users.sourceforge.net> Date: Thu Nov 21 21:33:59 2013 +0100 videodecoder: avoid descending output timestamps Fixes https://bugzilla.gnome.org/show_bug.cgi?id=712796