After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712612 - v4l2bufferpool: take over the floating reference for the new allocator
v4l2bufferpool: take over the floating reference for the new allocator
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-18 16:41 UTC by Michael Olbrich
Modified: 2014-01-17 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.18 KB, patch)
2013-11-18 16:41 UTC, Michael Olbrich 		reviewed Details | Review
patch (1.05 KB, patch)
2014-01-17 06:48 UTC, Michael Olbrich 		committed Details | Review

Description Michael Olbrich 2013-11-18 16:41:15 UTC 
Created attachment 260144 [details] [review]
patch

Otherwise the allocator will never be deleted.
Comment 1 Sebastian Dröge (slomo) 2013-11-26 12:27:13 UTC 
Comment on attachment 260144 [details] [review]
patch

This looks wrong, we should probably just make all GstAllocators non-floating in the instance_init function.

And the real bug in the previous code here is that we also ref() the newly created allocator. Everything should work just fine with your patch but without the ref_sink() call here
Comment 2 Nicolas Dufresne (ndufresne) 2014-01-15 18:49:05 UTC 
Is this still needed with all the changes that happened on master ?
Comment 3 Michael Olbrich 2014-01-17 06:48:04 UTC 
Created attachment 266524 [details] [review]
patch

Same as the last patch but without the ref_sink. Also rebased to latest master. It's still needed.
Comment 4 Nicolas Dufresne (ndufresne) 2014-01-17 13:34:16 UTC 
Review of attachment 266524 [details] [review]:

Looks good, I'll merge and push
Comment 5 Nicolas Dufresne (ndufresne) 2014-01-17 13:55:05 UTC 
Review of attachment 266524 [details] [review]:

commit 3d2bd4ff4975baac82885a258fa4ac21e90c7660
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date:   Fri Jan 17 07:46:09 2014 +0100

    v4l2bufferpool: don't ref the newly created allocator
    
    Otherwise the allocator will never be deleted.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=712612
Comment 6 Nicolas Dufresne (ndufresne) 2014-01-17 13:56:33 UTC 
No need to backport, I don't think dmabuf works there in stable branch, but correct me if I'm wrong.