After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712328 - matroskademux: Use GstVideoInfo helper to create caps for raw video
matroskademux: Use GstVideoInfo helper to create caps for raw video
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.2.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 712290
 
 
Reported: 2013-11-14 19:13 UTC by Thibault Saunier
Modified: 2013-11-26 11:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
matroskademux: Use GstVideoInfo helper to create caps for raw video (3.11 KB, patch)
2013-11-14 19:13 UTC, Thibault Saunier 		none Details | Review
matroskademux: Use GstVideoInfo helper to create caps for raw video (3.27 KB, patch)
2013-11-14 19:50 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2013-11-14 19:13:30 UTC 
This patch makes use of GstVideoInfo to create caps for raw video.
This way it sets default values for mandatory field of raw video caps.
Comment 1 Thibault Saunier 2013-11-14 19:13:33 UTC 
Created attachment 259836 [details] [review]
matroskademux: Use GstVideoInfo helper to create caps for raw video

This way we do not miss mandatory fields in caps.
Comment 2 Nicolas Dufresne (ndufresne) 2013-11-14 19:21:49 UTC 
Would be nice to fix the description field of GstVideoFormatInfo and use that, what do you think ?
Comment 3 Thibault Saunier 2013-11-14 19:50:51 UTC 
Created attachment 259838 [details] [review]
matroskademux: Use GstVideoInfo helper to create caps for raw video

This way we do not miss mandatory fields in caps.
At the same time use the gst_pb_utils_get_codec_description helper to
get codec description.
Comment 4 Thibault Saunier 2013-11-22 22:01:39 UTC 
Attachment 259838 [details] pushed as 6ff7522 - matroskademux: Use GstVideoInfo helper to create caps for raw video