After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712163 - context menus on links
context menus on links
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-12 17:05 UTC by Matthias Clasen
Modified: 2014-07-03 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
lib: Add a wrapper for gtk_widget_get_clipboard() (3.58 KB, patch)
2014-07-03 13:40 UTC, Florian Müllner
committed Details | Review
chatView: Add context menu to URLs (3.15 KB, patch)
2014-07-03 13:40 UTC, Florian Müllner
committed Details | Review

Description Matthias Clasen 2013-11-12 17:05:56 UTC
I habitually right-click on links to open them (maybe xchat habit). Sadly, the context menu shows no awareness at all what I just clicked on - I would expect 'Open' and 'Copy link' in the context menu.
Comment 1 Florian Müllner 2014-07-03 13:40:21 UTC
Created attachment 279841 [details] [review]
lib: Add a wrapper for gtk_widget_get_clipboard()

It takes an unintrospectable GdkAtom parameter, so we need a C helper.
Comment 2 Florian Müllner 2014-07-03 13:40:26 UTC
Created attachment 279842 [details] [review]
chatView: Add context menu to URLs

We currently only handle left clicks on URLs, so right clicks open
the default GtkTextView context menu instead of a context menu for
the clicked link as one would expect. Fix this by opening a simple
Open/Copy context menu when right-clicking URLs.
Comment 3 Florian Müllner 2014-07-03 13:41:56 UTC
Attachment 279841 [details] pushed as 3ba36e6 - lib: Add a wrapper for gtk_widget_get_clipboard()
Attachment 279842 [details] pushed as 82b9fe8 - chatView: Add context menu to URLs