GNOME Bugzilla – Bug 711721
mpegvideoparse: Unit test fails
Last modified: 2013-11-09 14:35:56 UTC
Running suite(s): mpegvideoparse 16%: Checks: 6, Failures: 5, Errors: 0 elements/parser.c:273:F:general:test_parse_normal:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (10) elements/parser.c:273:F:general:test_parse_split:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (20) elements/parser.c:273:F:general:test_parse_detect_stream_mpeg1:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (10) elements/parser.c:273:F:general:test_parse_detect_stream_mpeg2:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (10) elements/parser.c:273:F:general:test_parse_gop_split:0: 'g_list_length (buffers) - test->discard' (1) is not equal to 'frames' (10) Happens with 1.2.0, latest 1.2 branch and git master.
This is the commit that breaks it: commit e5ebd7d846a296f6018cf2af32fd229a4a05f424 Author: Matej Knopp <matej.knopp@gmail.com> Date: Tue Jul 30 15:17:23 2013 +0200 mpegvideoparse: support field encoding for interlaced video https://bugzilla.gnome.org/show_bug.cgi?id=705144
Well, it fails because all pictures in test have same TSN. That's not really supposed to happen in real stream, TSN is the only way to pair fields together. I don't know how to fix this since the data gets passed to gst_parser_test_normal
Created attachment 259320 [details] [review] Patch to only check for same TSN in interlaced streams Fixes the unit test by checking for same TSN only when the stream is interlaced.
commit 4930dc40cd8537e6004c9ec7c9f8467ee10284ad Author: Matej Knopp <matej.knopp@gmail.com> Date: Sat Nov 9 13:32:21 2013 +0100 mpegvideoparse: check for same TSN only for interlaced streams (fixes unit test) https://bugzilla.gnome.org/show_bug.cgi?id=711721