GNOME Bugzilla – Bug 711675
Prefill domain entry
Last modified: 2014-08-09 12:34:19 UTC
Created attachment 259261 [details] [review] prefil domain entry The enterprise domain should be prefilled according the mockup: https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/users/add-enterprise-user-account.png However current DHCP domain isn't mostly the right one. However if we already have any configured realm, we can use it. Would be better to use last used realm or most used realm if there is configured more of them, however not sure if there is any way to get this info.
Review of attachment 259261 [details] [review]: I'm reviewing it myself, because I've seen it differently in g-i-s... ::: panels/user-accounts/um-account-dialog.c @@ +680,3 @@ + /* Prefill domain entry by the existing one */ + ret = gtk_combo_box_get_active_iter (self->enterprise_domain, &iter); + if (!ret) { This condition isn't sufficient, because it doesn't care about the GtkEntry inside the GtkComboBox. It should be fixed same way as is in g-i-s: https://git.gnome.org/browse/gnome-initial-setup/tree/gnome-initial-setup/pages/account/gis-account-page-enterprise.c#n638
Created attachment 282805 [details] [review] prefill domain entry Prefill domain entry similar as is done in g-i-s. However currently I'm unable to test it fully due to the bug: https://bugzilla.redhat.com/show_bug.cgi?id=1061091
Review of attachment 282805 [details] [review]: Looks good.
Comment on attachment 282805 [details] [review] prefill domain entry commit e4efd5eafd3659d36b5a8ac818e8f2ada1bba768
Thanks for the review :-)