GNOME Bugzilla – Bug 711479
vaapisink: implement the GstNavigation interface
Last modified: 2014-09-16 11:52:53 UTC
Would be useful for things like DVD menus, where key/mouse events would need to be forwarded from the sink upstream.
(In reply to comment #0) > Would be useful for things like DVD menus, where key/mouse events would need to > be forwarded from the sink upstream. Is there a way to test that feature without a DVD or ISO? Thanks. :) From what I understand, it's basically useful to translating screen coords to video coords, right?
(In reply to comment #1) > (In reply to comment #0) > > Would be useful for things like DVD menus, where key/mouse events would need to > > be forwarded from the sink upstream. > > Is there a way to test that feature without a DVD or ISO? Thanks. :) You can use navigationtest element in plugins-good for testing. eg: Run gst-launch-1.0 videotestsrc ! navigationtest ! xvimagesink and move mouse pointer over the video :) > > From what I understand, it's basically useful to translating screen coords to > video coords, right?
Created attachment 286214 [details] [review] vaapisink: implement the GstNavigation interface
Review of attachment 286214 [details] [review]: LGTM. Thanks. ::: gst/vaapi/gstvaapisink.c @@ +121,3 @@ + gst_vaapisink_color_balance_iface_init); + G_IMPLEMENT_INTERFACE (GST_TYPE_NAVIGATION, + gst_vaapisink_navigation_iface_init)); We probably need to update gst_vaapisink_has_interface() as well for 0.10, even though I pretty don't much care of that.
(In reply to comment #4) > Review of attachment 286214 [details] [review]: > > LGTM. Thanks. > > ::: gst/vaapi/gstvaapisink.c > @@ +121,3 @@ > + gst_vaapisink_color_balance_iface_init); > + G_IMPLEMENT_INTERFACE (GST_TYPE_NAVIGATION, > + gst_vaapisink_navigation_iface_init)); > > We probably need to update gst_vaapisink_has_interface() as well for 0.10, even > though I pretty don't much care of that. Do we need to ??? I won't prefer, because then we have to support this new feature in 0.10 too. I didn't even compiling 0.10 nowadays :)
(In reply to comment #5) > (In reply to comment #4) > > Review of attachment 286214 [details] [review] [details]: > > > > LGTM. Thanks. > > > > ::: gst/vaapi/gstvaapisink.c > > @@ +121,3 @@ > > + gst_vaapisink_color_balance_iface_init); > > + G_IMPLEMENT_INTERFACE (GST_TYPE_NAVIGATION, > > + gst_vaapisink_navigation_iface_init)); > > > > We probably need to update gst_vaapisink_has_interface() as well for 0.10, even > > though I pretty don't much care of that. > > Do we need to ??? I won't prefer, because then we have to support this new > feature in 0.10 too. > I didn't even compiling 0.10 nowadays :) OK, you are right, it doesn't make sense to add new features to obsolete stacks anyway. :) Please try to push that patch as is then. Thanks.
commit 33212d96346e25726da59a533ed5f0af89cfd568 Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Tue Sep 16 14:25:40 2014 +0300 vaapisink: implement the GstNavigation interface This is useful for things like DVD menus, where key/mouse events would need to be forwarded from the upstream sink element. https://bugzilla.gnome.org/show_bug.cgi?id=711479