GNOME Bugzilla – Bug 711396
missing documentation about --notification --listen
Last modified: 2014-04-26 14:42:36 UTC
The manual page does list the option --listen (for --notification), but not the commands valid on stdin. The gnome documentation does not even list the option --listen: https://help.gnome.org/users/zenity/3.8/notification.html.de (and also not the commands of course) The commands on stdin for "zenity --notification --listen" are: icon: <name|path> message: <text> tooltip: <text> visible: <true|false> (according to http://muzso.hu/2009/05/26/zenity-gtk-dialogs-for-shell-scripts)
Hi! (In reply to comment #0) > The manual page does list the option --listen (for --notification), but not the > commands valid on stdin. What do you mean by this? I can see that the man page for zenity says.. --listen Listen for commands on stdin. Commands include 'message', 'tooltip', 'icon', and 'visible' separated by a colon. For example, 'message: Hello world', 'visible: false', or 'icon: /path/to/icon'. The icon command also accepts the four stock icon: 'error', 'info', 'question', and 'warn‐ ing' To me this is clear about the usage of the --listen option. > The gnome documentation does not even list the option --listen: > https://help.gnome.org/users/zenity/3.8/notification.html.de > (and also not the commands of course) Indeed that's because the mallard based help pages do not have any documentation on --listen. This is one issue and will require a patch to be filed. > The commands on stdin for "zenity --notification --listen" are: > icon: <name|path> > message: <text> > tooltip: <text> > visible: <true|false> > (according to http://muzso.hu/2009/05/26/zenity-gtk-dialogs-for-shell-scripts) Thank you for this bug report, I will file a patch soon.
Created attachment 259023 [details] [review] Add user help for --listen bug 711396
(In reply to comment #1) > Hi! > > (In reply to comment #0) > > The manual page does list the option --listen (for --notification), but not the > > commands valid on stdin. > > What do you mean by this? I can see that the man page for zenity says.. > > --listen > Listen for commands on stdin. Commands include 'message', > 'tooltip', 'icon', and 'visible' separated by a colon. For > example, 'message: Hello world', 'visible: false', or > 'icon: /path/to/icon'. The icon command also accepts the > four stock icon: 'error', 'info', 'question', and 'warn‐ > ing' > > To me this is clear about the usage of the --listen option. Agree. My local installation is older and the man pages I found on the internet did not show this as well. > > > The gnome documentation does not even list the option --listen: > > https://help.gnome.org/users/zenity/3.8/notification.html.de > > (and also not the commands of course) > > Indeed that's because the mallard based help pages do not have any > documentation on --listen. This is one issue and will require a patch to be > filed. > > > The commands on stdin for "zenity --notification --listen" are: > > icon: <name|path> > > message: <text> > > tooltip: <text> > > visible: <true|false> > > (according to http://muzso.hu/2009/05/26/zenity-gtk-dialogs-for-shell-scripts) > > Thank you for this bug report, I will file a patch soon. Thanks a lot.
Review of attachment 259023 [details] [review]: I wasn't able to apply the patch: Applying: Add user help for --listen, bug 711396 error: cannot apply binary patch to 'help/C/figures/zenity-notification-listen-screenshot.png' without full index line error: help/C/figures/zenity-notification-listen-screenshot.png: patch does not apply Can you check and resend the patch?
Thank you for the review, I will fix the patch and reupload again. Sorry about the inconvinience.
Created attachment 263078 [details] [review] Add user help for --listen bug 711396 Fixed patch.
Hello, Sorry for waste your time... I tried to apply your last patch and got this error: git am 0001-Add-user-help-for-listen-bug-711396.patch Applying: Add user help for --listen, bug 711396 error: help/C/figures/zenity-notification-listen-screenshot.png: already exists in index error: patch failed: help/C/notification.page:16 error: help/C/notification.page: patch does not apply Patch failed at 0001 Add user help for --listen, bug 711396 The copy of the patch that failed is found in: /home/arxcruz/Projetos/zenity/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Can you please review again? Kind regards, Arx Cruz
Created attachment 274898 [details] [review] help: Update notifications.page Sorry about the trouble. I noticed what I did wrong. I didn't remove the old image and the patch was trying to write a new image by the same name. Fixed up all that, tested the patch by applying it locally. Thanks.
Already on master. Thanks for your patch!