GNOME Bugzilla – Bug 711389
If an app is using a smaller icon, the row is shorter than usual
Last modified: 2015-05-11 16:41:41 UTC
Created attachment 258909 [details] screenshot I discovered on a laptop in this household that the application Autokey only shipped a 32x32 icon. While that is a bug in Autokey itself, it also seems that there is a bug in gnome-control-center in that the rows get too slim if there isn't a 48x48 icon to fill it.
perhaps another potential use of a css min-height property.
Besides the height of the row, the alignment of the label for Autokey also seems off - It is placed too far to the left, in comparison to the other labels: http://pasteboard.co/10J9eQ19.png
Created attachment 302646 [details] [review] align icons
Review of attachment 302646 [details] [review]: This looks good, can you upload a screenshot as well? ::: panels/notifications/cc-notifications-panel.c @@ +283,3 @@ gtk_widget_set_margin_bottom (w, 8); + gtk_size_group_add_widget (GTK_SIZE_GROUP (gtk_builder_get_object (panel->builder, "sizegroup1")), + w); No need to put 2 characters on another line. Our monitors are wide :)
Created attachment 302844 [details] [review] align icons Fixed.
Created attachment 302845 [details] screenshot (aligned)
Review of attachment 302844 [details] [review]: Looks good. Please cherry-pick in gnome-3-14 as well.
Comment on attachment 302844 [details] [review] align icons I've pushed the patch into master and gnome-3-14 branches. I've also added 'const' in front of the 'gchar *app_name' to avoid the warning about discarding of const qualifier.
(In reply to Marek Kašík from comment #8) > Comment on attachment 302844 [details] [review] [review] > align icons > > I've pushed the patch into master and gnome-3-14 branches. I've also added > 'const' in front of the 'gchar *app_name' to avoid the warning about > discarding of const qualifier. Sorry, wrong bug. I'm going to push this one right now.
Comment on attachment 302844 [details] [review] align icons (In reply to Bastien Nocera from comment #7) > Review of attachment 302844 [details] [review] [review]: > > Looks good. Please cherry-pick in gnome-3-14 as well. I've pushed this to master and gnome-3-14 branches.