GNOME Bugzilla – Bug 711280
Print Preview window is inconsistent with respect to the main window
Last modified: 2018-05-22 15:23:12 UTC
The Print Preview window has the old style toolbar, with colored buttons. It should be consistent with the main window.
I'd like to give this a try. It's marked as gnome-love bug and I've dug a little bit in the code, and I think I could, at least, start the work to fix this. It should be a work of one day max, I guess.
Created attachment 260041 [details] [review] Preliminary work on making previewer consistent wrt main Please note that many things are missing yet: - I've not found a document-print-symbolic icon, so I placed a status icon for completeness' sake, but I don't think this is acceptable. - Zoom actions are completely missing. Here I consider two options. The first one is to create a group of four icons holding the previous zoom actions, but now using symbolic icons. This solution fails because there are missing symbolic icons for best and width fit options. The second solution is to use the zoom-action developed as part of evince shell. This implies moving ev-action* to libmisc, as it's already done with ev-page*. Currently ev-action* depends on EvWindow, but I guess this dependency could be removed. I prefer this second option. Therefore, there are two points that need clarification: - What to do with document-print icon? - Is it accepted to move ev-action* to libmisc and remove the EvWindow dependency? Thank you.
The patch looks good in general, but it needs to be updated to match current main window. - Use a header bar - Move to GAction Regarding the icons. For the printer we can simply use printer-symbolic, and we can simply the UI by removing the best-fit/fit-width icons and using automatic sizing mode unconditionally, and zoom in/out buttons.
Thank you. I'll update it to use GAction, and move the tool buttons to a header bar.
Created attachment 288859 [details] [review] Migrate to GAction and use header bar. I have left some lines commented out in the patch because I do not know if I can remove them (I mean, their equivalents). They refer to sensitivity of installed actions; however, I do not understand why sensitivity changes in some cases, e.g. when EvView receives/losses focus.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/405.