After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711051 - Add basic test for the GNotification gtk backend
Add basic test for the GNotification gtk backend
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gapplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-10-29 07:10 UTC by Lars Karlitski
Modified: 2013-11-23 20:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk-notification-backend: remove unused variable (2.90 KB, patch)
2013-10-29 07:10 UTC, Lars Karlitski 		committed Details | Review
Add basic test for the GNotification gtk backend (20.17 KB, patch)
2013-10-29 07:10 UTC, Lars Karlitski 		committed Details | Review

Description Lars Karlitski 2013-10-29 07:10:37 UTC 
This introduces GNotificationServer and a simple test using it into gio/tests.
GNotificationServer is a server-side implementation of the protocol described
in http://wiki.gnome.org/GNotification.

This is still work in progress. I want to add some more elaborate tests with
multiple GApplications. Just putting it here for people to have a look at.

The second commit fixes the first (slightly embarrassing) bug that the test has
uncovered.
Comment 1 Lars Karlitski 2013-10-29 07:10:39 UTC 
Created attachment 258411 [details] [review]
gtk-notification-backend: remove unused variable

A reference to the session bus is now stored in GNotificationBackend.
Remove the extraneous one in the gtk backend and stop using it in
withdraw_notification.
Comment 2 Lars Karlitski 2013-10-29 07:10:41 UTC 
Created attachment 258412 [details] [review]
Add basic test for the GNotification gtk backend
Comment 3 Allison Karlitskaya (desrt) 2013-10-29 15:55:20 UTC 
Review of attachment 258411 [details] [review]:

Yes, please :)
Comment 4 Lars Karlitski 2013-10-29 16:04:07 UTC 
Comment on attachment 258411 [details] [review]
gtk-notification-backend: remove unused variable

Attachment 258411 [details] pushed as 425f307 - gtk-notification-backend: remove unused variable
Comment 5 Matthias Clasen 2013-11-23 04:44:42 UTC 
Review of attachment 258412 [details] [review]:

Lets get this in - a basic test is better than no test.
Comment 6 Matthias Clasen 2013-11-23 20:20:38 UTC 
Attachment 258412 [details] pushed as 65da592 - Add basic test for the GNotification gtk backend