After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711003 - videoscale: borders are filled with green when using NV12 pixelformat
videoscale: borders are filled with green when using NV12 pixelformat
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.2.0
Other All
: Normal normal
: 1.2.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-28 11:44 UTC by Antonio Ospite
Modified: 2013-10-30 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videoscale: fix adding borders when NV12 is used (1.21 KB, patch)
2013-10-28 11:45 UTC, Antonio Ospite
committed Details | Review

Description Antonio Ospite 2013-10-28 11:44:39 UTC
Hi,

when using videoscale with add-borders=1 and the NV12 pixelformat the borders result filled in green.

This is the test pipeline which shows the problem:

gst-launch-1.0 videotestsrc ! video/x-raw,format=NV12,width=640,height=480 ! videoscale add-borders=1 ! video/x-raw,width=800,height=480,pixel-aspect-ratio=1/1 ! videoconvert ! autovideosink

This is because the borders are not filled in black explicitly when NV12 is used, the attached patch fixes the issue, but maybe there is a better way to do it.

BTW, I came across a similar issue with the rotate plugin:
https://bugzilla.gnome.org/show_bug.cgi?id=710392

I can understand that the operation "filling a frame buffer in black" is not that simple as it appears when taking into account different pixel formats, so maybe a "library" way to fill frame buffers with a given color could be added to GStreamer.

Just an idea, I don't have development time to spend on such a project right now.

Thanks,
   Antonio
Comment 1 Antonio Ospite 2013-10-28 11:45:39 UTC
Created attachment 258290 [details] [review]
videoscale: fix adding borders when NV12 is used
Comment 2 Sebastian Dröge (slomo) 2013-10-30 17:39:04 UTC
commit fdfc6baf14766e14918fdbc39bc18366e7f89c59
Author: Antonio Ospite <ospite@studenti.unina.it>
Date:   Mon Oct 28 12:36:04 2013 +0100

    videoscale: fix adding borders when NV12 is used
    
    When the frame buffer is NV12 the borders are not added at all, fix that
    and fill them to black.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=711003